Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: test broken link checker on vercel preview deploy [sc-00] #926

Closed
wants to merge 25 commits into from

Conversation

ndom91
Copy link
Contributor

@ndom91 ndom91 commented Oct 12, 2023

Affected Components

  • Content & Marketing
  • Pricing
  • Test
  • Docs
  • Learn
  • Other

Pre-Requisites

  • Code is linted (npm run lint)

Notes for the Reviewer

New Dependency Submission

  • Test Vercel preview deploy broken link checker
  • Currenlty dummy waits for 3m (180s) if the Vercel deployment_status != 'READY'
    • Tried to use the dynamic https://github.com/UnlyEd/github-action-await-vercel, but it couldn't ever find the deploy for some reason. Maybe because I'm using a token from my personal account, not Checkly's 🤔
    • Our docs page almost always takes 2m20s (140s) to build though, so this should be fine
  • Forked celinekurpershoek/link-checker for actually walking through all the links and testing them. That GHA worked just fine on its own, however, the output that it used to comment on this PR didn't include the broken links themselves, it would just say "found X broken links out of Y links found".. With our fork in here it also includes the broken links themselves in the comment body
    • The only change from the upstream is the multiline comment body which includes the actual broken links themselves. Found at: .github/link-checker/entrypoint.sh:63-68
    • See below for example comment output with broken links 🥳

Screenshots

@vercel
Copy link

vercel bot commented Oct 12, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
checklyhq-com ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 9, 2023 0:45am

@ndom91 ndom91 mentioned this pull request Oct 12, 2023
7 tasks
@vercel vercel bot temporarily deployed to staging October 12, 2023 12:08 Inactive
@vercel vercel bot temporarily deployed to staging October 12, 2023 12:15 Inactive
@vercel vercel bot temporarily deployed to staging October 12, 2023 12:23 Inactive
@vercel vercel bot temporarily deployed to staging October 12, 2023 12:26 Inactive
@vercel vercel bot temporarily deployed to staging October 12, 2023 12:37 Inactive
@vercel vercel bot temporarily deployed to staging October 12, 2023 12:47 Inactive
@vercel vercel bot temporarily deployed to staging October 12, 2023 13:02 Inactive
@github-actions
Copy link

github-actions bot commented Oct 12, 2023

1 broken link(s) found (out of 34522 total)

[✗] hhttps://pptr.dev/#?product=Puppeteer&version=v10.2.0&show=api-class-elementhandle
[✗] https://checklyhq-iwf33nons-checkly.vercel.app/blog/how-to-bypass-totp-based-2fa-login-flows-with-playwright/
[✗] https://checklyhq-iwf33nons-checkly.vercel.app/blog/scaling-puppeteer-playwright-on-checkly-with-terraform/#grouping-checks-together
[✗] https://checklyhq-iwf33nons-checkly.vercel.app/blog/scaling-puppeteer-playwright-on-checkly-with-terraform/#iterating-through-scripts-for-shorter-config
[✗] https://checklyhq-iwf33nons-checkly.vercel.app/blog/scaling-puppeteer-playwright-on-checkly-with-terraform/#reducing-code-duplication-with-snippets
[✗] https://checklyhq-iwf33nons-checkly.vercel.app/blog/what-is-api-monitoring/
[✗] https://checklyhq-iwf33nons-checkly.vercel.app/docs/alerting/alert-channels
[✗] https://checklyhq-iwf33nons-checkly.vercel.app/docs/alerting/alert-channels/#managing-alert-channels
[✗] https://checklyhq-iwf33nons-checkly.vercel.app/docs/alerting/phone-calls
[✗] https://checklyhq-iwf33nons-checkly.vercel.app/docs/alerting/phone-calls/
[✗] https://checklyhq-iwf33nons-checkly.vercel.app/docs/alerting/sms-delivery/
[✗] https://checklyhq-iwf33nons-checkly.vercel.app/docs/alerting/ssl-expiration/
[✗] https://checklyhq-iwf33nons-checkly.vercel.app/docs/alerting/webhooks
[✗] https://checklyhq-iwf33nons-checkly.vercel.app/docs/alerting/webhooks/
[✗] https://checklyhq-iwf33nons-checkly.vercel.app/docs/alerting/webhooks/#using-variables
[✗] https://checklyhq-iwf33nons-checkly.vercel.app/docs/api
[✗] https://checklyhq-iwf33nons-checkly.vercel.app/docs/api/
[✗] https://checklyhq-iwf33nons-checkly.vercel.app/docs/assertions
[✗] https://checklyhq-iwf33nons-checkly.vercel.app/docs/limits
[✗] https://checklyhq-iwf33nons-checkly.vercel.app/docs/request-settings
[✗] https://checklyhq-iwf33nons-checkly.vercel.app/docs/setup-teardown-scripts
[✗] https://checklyhq-iwf33nons-checkly.vercel.app/pricing
[✗] https://checklyhq-iwf33nons-checkly.vercel.app/product/private-locations/
[✗] https://checklyhq-iwf33nons-checkly.vercel.app/slack

@vercel vercel bot temporarily deployed to staging October 12, 2023 13:25 Inactive
@vercel vercel bot temporarily deployed to staging October 12, 2023 14:09 Inactive
@vercel vercel bot temporarily deployed to staging October 12, 2023 14:32 Inactive
@vercel vercel bot temporarily deployed to staging October 12, 2023 14:42 Inactive
@vercel vercel bot temporarily deployed to staging October 12, 2023 15:53 Inactive
@vercel vercel bot temporarily deployed to staging October 12, 2023 17:32 Inactive
@vercel vercel bot temporarily deployed to staging October 13, 2023 12:29 Inactive
@vercel vercel bot temporarily deployed to staging October 13, 2023 12:52 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant