-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: test broken link checker on vercel preview deploy [sc-00] #926
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
…heckly/checklyhq.com into ndom91/sc-00/broken-link-checker
ndom91
requested review from
maxigimenez,
umutuzgur and
shiini2
and removed request for
maxigimenez,
umutuzgur and
shiini2
November 9, 2023 12:43
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Affected Components
Pre-Requisites
npm run lint
)Notes for the Reviewer
New Dependency Submission
180s
) if the Verceldeployment_status != 'READY'
140s
) to build though, so this should be finecelinekurpershoek/link-checker
for actually walking through all the links and testing them. That GHA worked just fine on its own, however, the output that it used to comment on this PR didn't include the broken links themselves, it would just say "found X broken links out of Y links found".. With our fork in here it also includes the broken links themselves in the comment body.github/link-checker/entrypoint.sh:63-68
Screenshots