-
-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support svelte 5.16.0 class value #2142
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@calvo-jp is attempting to deploy a commit to the Chakra UI Team on Vercel. A member of the Team first needs to authorize it. |
@calvo-jp It's probably better to make this change in the svelte adapter https://github.com/chakra-ui/zag/blob/main/packages/frameworks/svelte/src/merge-props.ts |
Hi @anubra266. Will update my PR once I get back. Thank you! |
After thinking deeply about this, we don't want to include this logic in zag.js since we don't use classNames in our components or logic. Please include this in your userland or library code instead. Thanks for opening this. |
Closes #
📝 Description
In Svelte
5.16.0
, the class attribute accepts objects and arrays as values using clsx under the hood. This PR adds support for this feature. (code taken fromclsx
)⛳️ Current behavior (updates)
Input:
Output:
🚀 New behavior
Input:
Output:
💣 Is this a breaking change (Yes/No):
No
📝 Additional Information