Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(jest): support ts/tsx test files #6684

Conversation

matthewgallo
Copy link
Member

We'll likely want to be writing more tests in TypeScript moving forward, this PR updates our jest config to run test files with ts or tsx extensions.

What did you change?

config/jest-config-ibm-cloud-cognitive/index.js

How did you test and verify your work?

Existing tests still run as expected

@matthewgallo matthewgallo requested a review from a team as a code owner January 10, 2025 19:11
@matthewgallo matthewgallo requested review from makafsal and anamikaanu96 and removed request for a team January 10, 2025 19:11
Copy link

netlify bot commented Jan 10, 2025

Deploy Preview for ibm-products-web-components ready!

Name Link
🔨 Latest commit 03c2223
🔍 Latest deploy log https://app.netlify.com/sites/ibm-products-web-components/deploys/678170e68e635f0008e8c125
😎 Deploy Preview https://deploy-preview-6684--ibm-products-web-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jan 10, 2025

Deploy Preview for carbon-for-ibm-products ready!

Name Link
🔨 Latest commit 03c2223
🔍 Latest deploy log https://app.netlify.com/sites/carbon-for-ibm-products/deploys/678170e6b078e10008cbe573
😎 Deploy Preview https://deploy-preview-6684--carbon-for-ibm-products.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Jan 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.67%. Comparing base (90dc01c) to head (03c2223).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6684   +/-   ##
=======================================
  Coverage   80.67%   80.67%           
=======================================
  Files         397      397           
  Lines       12923    12923           
  Branches     4286     4286           
=======================================
  Hits        10425    10425           
  Misses       2498     2498           
Components Coverage Δ
ibm-products ∅ <ø> (∅)
ibm-products-web-components ∅ <ø> (∅)

Copy link
Contributor

@davidmenendez davidmenendez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

Copy link
Contributor

@anamikaanu96 anamikaanu96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@anamikaanu96 anamikaanu96 added this pull request to the merge queue Jan 13, 2025
Merged via the queue into carbon-design-system:main with commit 9f651fe Jan 13, 2025
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants