-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(sidePanel): resolve storybook doc page scroll issues #6664
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for ibm-products-web-components ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-for-ibm-products ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6664 +/- ##
==========================================
- Coverage 80.78% 80.68% -0.10%
==========================================
Files 396 397 +1
Lines 12894 12923 +29
Branches 4275 4286 +11
==========================================
+ Hits 10416 10427 +11
- Misses 2478 2496 +18
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The slideIn
panel doesn't work as expected with these changes because the element with id
ibm-products-page-content
was removed.
Closes #6623
What did you change?
overflow: hidden
forbody
How did you test and verify your work?
storybook