-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(scrollgradient, stringformatter, truncatedlist, webterminal): csp #6346
base: main
Are you sure you want to change the base?
fix(scrollgradient, stringformatter, truncatedlist, webterminal): csp #6346
Conversation
✅ Deploy Preview for carbon-for-ibm-products ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for ibm-products-web-components ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6346 +/- ##
==========================================
+ Coverage 80.67% 80.71% +0.04%
==========================================
Files 397 397
Lines 12923 12952 +29
Branches 4286 4291 +5
==========================================
+ Hits 10425 10454 +29
Misses 2498 2498
|
@AlexanderMelox still seeing some build failures. can you confirm if these are happening locally or just here? thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just spotted some style differences with TruncatedList
and WebTerminal
.
TruncatedList
appears to have lost a transition when you click view all, it also displays all items whereas in the current storybook only the first 9 items are visible. Same thing with WebTerminal
, if you close the terminal and reopen, the animation is gone.
i'm seeing the same thing |
Closes #6191
This PR fixes CSP violations in the following components:
What did you change?
Removed inline styles, and added them with useIsomorphicEffect
How did you test and verify your work?
Storybook