Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(scrollgradient, stringformatter, truncatedlist, webterminal): csp #6346

Open
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

AlexanderMelox
Copy link
Contributor

Closes #6191

This PR fixes CSP violations in the following components:

  • ScrollGradient
  • StringFormatter
  • TruncatedList
  • WebTerminal

What did you change?

Removed inline styles, and added them with useIsomorphicEffect

How did you test and verify your work?

Storybook

@AlexanderMelox AlexanderMelox requested a review from a team as a code owner November 1, 2024 19:49
@AlexanderMelox AlexanderMelox requested review from davidmenendez and amal-k-joy and removed request for a team November 1, 2024 19:49
Copy link

netlify bot commented Nov 1, 2024

Deploy Preview for carbon-for-ibm-products ready!

Name Link
🔨 Latest commit ebb9b66
🔍 Latest deploy log https://app.netlify.com/sites/carbon-for-ibm-products/deploys/67817395d7b3c80008df8275
😎 Deploy Preview https://deploy-preview-6346--carbon-for-ibm-products.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Nov 1, 2024

Deploy Preview for ibm-products-web-components ready!

Name Link
🔨 Latest commit ebb9b66
🔍 Latest deploy log https://app.netlify.com/sites/ibm-products-web-components/deploys/67817395679dd90008df050d
😎 Deploy Preview https://deploy-preview-6346--ibm-products-web-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

amal-k-joy
amal-k-joy previously approved these changes Nov 4, 2024
Copy link
Contributor

@amal-k-joy amal-k-joy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good

@amal-k-joy amal-k-joy self-requested a review November 4, 2024 10:41
@amal-k-joy amal-k-joy dismissed their stale review November 4, 2024 11:12

ci checks failing

@AlexanderMelox AlexanderMelox added the hacktoberfest https://hacktoberfest.com/ label Nov 4, 2024
Copy link

codecov bot commented Nov 6, 2024

Codecov Report

Attention: Patch coverage is 87.17949% with 5 lines in your changes missing coverage. Please review.

Project coverage is 80.71%. Comparing base (90dc01c) to head (ebb9b66).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6346      +/-   ##
==========================================
+ Coverage   80.67%   80.71%   +0.04%     
==========================================
  Files         397      397              
  Lines       12923    12952      +29     
  Branches     4286     4291       +5     
==========================================
+ Hits        10425    10454      +29     
  Misses       2498     2498              
Components Coverage Δ
ibm-products ∅ <ø> (∅)
ibm-products-web-components ∅ <ø> (∅)

@davidmenendez
Copy link
Contributor

@AlexanderMelox still seeing some build failures. can you confirm if these are happening locally or just here? thanks.

Copy link
Member

@matthewgallo matthewgallo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just spotted some style differences with TruncatedList and WebTerminal.

TruncatedList appears to have lost a transition when you click view all, it also displays all items whereas in the current storybook only the first 9 items are visible. Same thing with WebTerminal, if you close the terminal and reopen, the animation is gone.

@davidmenendez
Copy link
Contributor

Just spotted some style differences with TruncatedList and WebTerminal.

TruncatedList appears to have lost a transition when you click view all, it also displays all items whereas in the current storybook only the first 9 items are visible. Same thing with WebTerminal, if you close the terminal and reopen, the animation is gone.

i'm seeing the same thing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest https://hacktoberfest.com/
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Address CSP in utility components
5 participants