Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(button-group): clean up styles #11200

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

chore(button-group): clean up styles #11200

wants to merge 9 commits into from

Conversation

andy-blum
Copy link
Contributor

Related Ticket(s)

Closes #11198

Description

  • Breaks button-group and button-group-item styles into separate files
  • Migrates component styles solely into web-components package
  • Removes unnecessary style imports & rules

Changelog

Changed

  • Cleans up styles of button-group and button-group-item

@andy-blum andy-blum requested a review from a team as a code owner December 5, 2023 16:44
@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Dec 5, 2023 •
edited
Loading

Deploy preview created for package Carbon Web Components:
https://carbon-web-components.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/11200/index.html

Built with commit: 3b7fe5272835827276127645473bf19853d75ee4

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Dec 5, 2023 •
edited
Loading

Deploy preview created for package Web Components (React wrapper):
https://ibmdotcom-web-components-react.s3-web.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/11200/index.html

Built with commit: 3b7fe5272835827276127645473bf19853d75ee4

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Dec 5, 2023 •
edited
Loading

Deploy preview created for package Web Components:
https://ibmdotcom-webcomponents.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/11200/index.html

Built with commit: 3b7fe5272835827276127645473bf19853d75ee4

jkaeser
jkaeser suggested changes Dec 22, 2023
View reviewed changes
Copy link
Member

@jkaeser jkaeser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The icons have gone missing in the default button story.

m4olivei
m4olivei approved these changes Jan 2, 2024
View reviewed changes
Copy link
Contributor

@m4olivei m4olivei left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking good to me. I don't see the same issue that @jkaeser reported for the default button group:

Monosnap screencast 2024-01-02 10-00-21

@jkaeser
Copy link
Member

jkaeser commented Jan 2, 2024

Well I'll be, I'm not seeing the missing icons anymore either. Must be ghosts. Approved!

@m4olivei m4olivei added the owner: Innovation Team used when the engineering work will be done by Hybrid Cloud with DDS engineers as consultants label Feb 1, 2024
@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Feb 27, 2024 •
edited
Loading

Deploy preview created for package Web Components HTML Test Application:
https://ibmdotcom-web-components-html-test-upstream.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/11200/index.html

Built with commit: 3b7fe5272835827276127645473bf19853d75ee4

@netlify Netlify
Copy link

netlify bot commented Dec 11, 2024 •
edited
Loading

✅ Deploy Preview for ibm-dotcom-web-components-react-wrap ready!

Name Link
🔨 Latest commit 47945ef
🔍 Latest deploy log https://app.netlify.com/sites/ibm-dotcom-web-components-react-wrap/deploys/6769696fa690ae0008938ff7
😎 Deploy Preview https://deploy-preview-11200--ibm-dotcom-web-components-react-wrap.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify Netlify
Copy link

netlify bot commented Dec 13, 2024 •
edited
Loading

✅ Deploy Preview for ibm-dotcom-web-components ready!

Name Link
🔨 Latest commit 47945ef
🔍 Latest deploy log https://app.netlify.com/sites/ibm-dotcom-web-components/deploys/6769696ffa24680008e5f37c
😎 Deploy Preview https://deploy-preview-11200--ibm-dotcom-web-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@m4olivei
Copy link
Contributor

@andy-blum is this still worth adopting? When we last were talking about it, John and I were both good with it, and we were only waiting on DPO.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkaeser jkaeser jkaeser approved these changes

@m4olivei m4olivei m4olivei approved these changes

@ariellalgilmore ariellalgilmore Awaiting requested review from ariellalgilmore ariellalgilmore is a code owner automatically assigned from carbon-design-system/carbon-for-ibm-com-members

@sangeethababu9223 sangeethababu9223 Awaiting requested review from sangeethababu9223 sangeethababu9223 is a code owner automatically assigned from carbon-design-system/carbon-for-ibm-com-members

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
owner: Innovation Team used when the engineering work will be done by Hybrid Cloud with DDS engineers as consultants
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

button group
6 participants
@andy-blum @ibmdotcom-bot @jkaeser @m4olivei @annawen1 @kennylam