Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add shared lib build to ubuntu and nightly #3975

Merged
merged 1 commit into from
Jan 15, 2025
Merged

Add shared lib build to ubuntu and nightly #3975

merged 1 commit into from
Jan 15, 2025

Conversation

midokura-xavi92
Copy link
Contributor

So far, no workflows would attempt to build the shared version of the iwasm library (namely, vmlib).

Note that, as opposed to GC_EH_BUILD_OPTIONS and DEFAULT_BUILD_OPTIONS, the actual default options defined by the build system are assumed, for the sake of simplicity and avoiding repeated code.

@midokura-xavi92 midokura-xavi92 force-pushed the ci-shared branch 2 times, most recently from a2215b4 to 492ccc6 Compare December 19, 2024 14:20
@midokura-xavi92 midokura-xavi92 mentioned this pull request Dec 19, 2024
Open
@midokura-xavi92 midokura-xavi92 marked this pull request as ready for review December 19, 2024 15:59
@lum1n0us
Copy link
Collaborator

Are we planning to include a shared library in the final set of release binaries, or are we going to test the compilation of a shared library with each PR? If it's the former, then modifying build_iwasm_release.yml makes sense. However, if it's the latter, you might want to make changes to .github/workflows/compilation_on_* instead.

@midokura-xavi92
Copy link
Contributor Author

Are we planning to include a shared library in the final set of release binaries, or are we going to test the compilation of a shared library with each PR? If it's the former, then modifying build_iwasm_release.yml makes sense. However, if it's the latter, you might want to make changes to .github/workflows/compilation_on_* instead.

I do not decide which artifacts should be built for release, so I assume the latter only for now. I will then update the PR to only modify _.github/workflows/compilation_on__*.

@lum1n0us
Copy link
Collaborator

lum1n0us commented Jan 9, 2025

@midokura-xavi92 I noticed that the PR has been inactive for a few weeks. It looks like it’s almost ready to be merged, and it would be great to see it completed. Would you be able to make the necessary modifications? If you need any help or have any questions, please feel free to reach out. Your contribution is highly appreciated!

@midokura-xavi92
Copy link
Contributor Author

@lum1n0us I have just updated the branch so as to modify .github/workflows/compilation_on_android_ubuntu.yml. If you agree with the proposal, I can extend it to .github/workflows/compilation_on_sgx.yml or any other workflows you might prefer.

@midokura-xavi92 midokura-xavi92 changed the title build_iwasm_release.yml: Add shared lib build compilation_on_android.yml: Add shared lib build Jan 9, 2025
@midokura-xavi92
Copy link
Contributor Author

Thanks for the tips, @lum1n0us . Please let me know whether the changes are valid now.

@midokura-xavi92 midokura-xavi92 force-pushed the ci-shared branch 2 times, most recently from b03b869 to 7e414d1 Compare January 10, 2025 09:10
@lum1n0us
Copy link
Collaborator

I will then update the PR to only modify .github/workflows/compilation_on_*.

Additionally, since android does not support WAMR_BUILD_SHARED in its CMakeLists.txt, we should exclude that combination. Please add something into the exclude group.

  - make_options_feature: "-DWAMR_BUILD_SHARED=1"
    platform: android

Then I think it's good to go.

@midokura-xavi92
.github: Add shared lib builds
8a43475 
So far, no workflows would attempt to build the shared version of the
iwasm library (namely, vmlib).

Note that, as opposed to GC_EH_BUILD_OPTIONS and DEFAULT_BUILD_OPTIONS,
the actual default options defined by the build system are assumed, for
the sake of simplicity and avoiding repeated code.
@midokura-xavi92
Copy link
Contributor Author

I will then update the PR to only modify .github/workflows/compilation_on_*.

Additionally, since android does not support WAMR_BUILD_SHARED in its CMakeLists.txt, we should exclude that combination. Please add something into the exclude group.

  - make_options_feature: "-DWAMR_BUILD_SHARED=1"
    platform: android

Then I think it's good to go.

Done, thank you!

wenyongh
wenyongh approved these changes Jan 15, 2025
View reviewed changes
Copy link
Contributor

@wenyongh wenyongh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

lum1n0us
lum1n0us approved these changes Jan 15, 2025
View reviewed changes
Copy link
Collaborator

@lum1n0us lum1n0us left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lum1n0us
Copy link
Collaborator

I will then update the PR to only modify .github/workflows/compilation_on_*.

@midokura-xavi92 Is this everything, or are there more forthcoming?

@midokura-xavi92 midokura-xavi92 changed the title compilation_on_android.yml: Add shared lib build Add shared lib build to android/ubuntu and nightly Jan 15, 2025
@midokura-xavi92 midokura-xavi92 changed the title Add shared lib build to android/ubuntu and nightly Add shared lib build to ubuntu and nightly Jan 15, 2025
@midokura-xavi92
Copy link
Contributor Author

I will then update the PR to only modify .github/workflows/compilation_on_*.

@midokura-xavi92 Is this everything, or are there more forthcoming?

I guess we can merge this for now and think about other targets later. WDYT @lum1n0us ?

@lum1n0us
Copy link
Collaborator

fine by me

@lum1n0us lum1n0us merged commit 1ac62e1 into bytecodealliance:main Jan 15, 2025
482 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lum1n0us lum1n0us lum1n0us approved these changes

@wenyongh wenyongh wenyongh approved these changes

@loganek loganek Awaiting requested review from loganek loganek is a code owner

@no1wudi no1wudi Awaiting requested review from no1wudi no1wudi is a code owner

@xujuntwt95329 xujuntwt95329 Awaiting requested review from xujuntwt95329 xujuntwt95329 is a code owner

@yamt yamt Awaiting requested review from yamt yamt is a code owner

@TianlongLiang TianlongLiang Awaiting requested review from TianlongLiang TianlongLiang is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@midokura-xavi92 @lum1n0us @wenyongh