Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes to support WASI on Zephyr #3948

Conversation

srberard
Copy link
Contributor

@srberard srberard commented Dec 5, 2024

Fixed issues #3311.

@wenyongh I'm merging this to the branch created so that we can review and ensure all the items are addressed prior to merging back to main.

Fixed issues in os_renameat

Signed-off-by: Stephen Berard <[email protected]>
@srberard
Copy link
Contributor Author

srberard commented Dec 5, 2024

There is 1 testing failing above, but I don't believe it's related to this PR.

@lum1n0us
Copy link
Collaborator

lum1n0us commented Dec 6, 2024

There is 1 testing failing above, but I don't believe it's related to this PR.

It's not related. Don't be worried.

Copy link
Collaborator

@lum1n0us lum1n0us left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@wenyongh wenyongh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wenyongh
Copy link
Contributor

There is 1 testing failing above, but I don't believe it's related to this PR.

I remember this issue was fixed in main branch and the commits in main branch had been merged into this branch. Maybe you can rebase you code to run CIs again.

@srberard
Copy link
Contributor Author

There is 1 testing failing above, but I don't believe it's related to this PR.

I remember this issue was fixed in main branch and the commits in main branch had been merged into this branch. Maybe you can rebase you code to run CIs again.

Sure, I'll get this done shortly.

@wenyongh wenyongh merged commit e3b0244 into bytecodealliance:dev/zephyr_file_socket Jan 15, 2025
383 checks passed
@srberard
Copy link
Contributor Author

@wenyongh Do we have a plan for when this will be merged into the mainline or do you need me to create a PR for this?

@wenyongh
Copy link
Contributor

If there is no another patches for this branch, we can consider merging it to main branch. I think we had better create a new release (WAMR-2.2.1) before merging this branch into main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants