feat: use postgres for managed nodes #8735
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etorreborre
force-pushed
the
etorreborre/feat/migrate-sqlite-to-postgres
branch
4 times, most recently
from
e1b0bf4 to
dbdaa6e
Compare
etorreborre
force-pushed
the
etorreborre/feat/migrate-sqlite-to-postgres
branch
10 times, most recently
from
3d8e0bc to
b953582
Compare
etorreborre
force-pushed
the
etorreborre/feat/migrate-sqlite-to-postgres
branch
from
b953582 to
18f85f5
Compare
etorreborre
force-pushed
the
etorreborre/feat/migrate-sqlite-to-postgres
branch
6 times, most recently
from
e57cc59 to
23b9807
Compare
etorreborre
force-pushed
the
etorreborre/feat/migrate-sqlite-to-postgres
branch
from
23b9807 to
c0cd6ed
Compare
auto-merge was automatically disabled
January 22, 2025 15:28
Pull request was converted to draft
adrianbenavides
approved these changes
Jan 23, 2025
implementations/rust/ockam/ockam_node/src/storage/database/database_configuration.rs
Show resolved
Hide resolved
...ntations/rust/ockam/ockam_node/src/storage/database/migrations/migration_support/migrator.rs
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a Rust migration to import the data from a SQLite node to a shared Postgres database for managed nodes.
The main difficulty for this PR consists in passing the legacy SQLite database path down to the migration code, hence the modifications on the
migrator.rsstructs.This migration only applies once per migrated node if the Postgres database is configured. For this specific migration we use the SQLite database to mark the node as migrated and there's no mention of that migration in the Postgres database.
I also simplified the return value of the
migratemethod which returnsResult<()>now since the previously returned boolean was alwaystrue.Note that this code only runs if the Postgres database is enabled.