Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mnt/annotate keyboard methods #58

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

welli7ngton
Copy link

@welli7ngton welli7ngton commented Dec 28, 2024

  • MNT: Annotate all keyboard methods
  • style: set double quotes as default quoting, before had no default quoting and
    some methods were using single quotes and some were using double, my formatter (black)
    changed all the quotes to double quotes, and changed the indent of methods (
    find_multiple, find, find_until, find_all, find_text,
    click, click_relative, double_click_relative,
    triple_click_relative, right_click, right_click_relative,
    find_app_element
    )

@welli7ngton
Copy link
Author

Sorry for the size of the PR, guys, but had some 'automate' changes because of the black formatter and the keyboard session is pretty big ;)

@joao-voltarelli
Copy link
Contributor

@welli7ngton great work!

Just an observation, I noticed that in some keyboard methods, the parameter type or return type was missing:

  • type_key
  • type_keys_with_interval
  • type_keys
  • copy_to_clipboard
  • key_enter
  • Some methods that use alt_<key>
  • Some methods that use control_<key>

Could you please revisit these methods to validate if any adjustments are needed?

@welli7ngton
Copy link
Author

@joao-voltarelli Alright, asap i'll be solving this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants