Snakemake data loader maintenance #166
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Snakemake pipeline was giving a lot of issues. First was the version of python in the Node:16 container was unable to parse syntax in the node-gyp module, specifically the := operator. Updating the container to Node:17 was enough to solve this. With the update to Node:17, the 1.x.x version of the graphkb_parser was no longer working within the node dependency chain. I updated the graphkb_parser to ^2.0.0 and graphkb-schema to ^3.16.0 which allowed all dependencies to compile. Updating the parser changed how it was to be loaded in the javascript code, so there were a few superficial changes to get the library loaded. The shell sections of many downloaders included commands to change directory. I don't know if this was causing all the problems or the dedent command, but for me the shell sections of these tasks would execute and exit without error, but without having run any commands. I reworked these tasks to download files without changing directory, often by replacing wget with `curl --create-dirs -o`. Was still having some Node version issues when executing the pipeline, but npm rebuild seemed to fix that. I'm not sure if something else could be done to fix that, but putting an `npm rebuild` near the end of the Docker file was enough to solve that problem for me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Snakemake pipeline was giving a lot of issues. First was the version of python in the Node:16 container was unable to parse syntax in the node-gyp module, specifically the := operator. Updating the container to Node:17 was enough to solve this.
With the update to Node:17, the 1.x.x version of the graphkb_parser was no longer working within the node dependency chain. I updated the graphkb_parser to ^2.0.0 and graphkb-schema to ^3.16.0 which allowed all dependencies to compile. Updating the parser changed how it was to be loaded in the javascript code, so there were a few superficial changes to get the library loaded.
The shell sections of many downloaders included commands to change directory. I don't know if this was causing all the problems or the dedent command, but for me the shell sections of these tasks would execute and exit without error, but without having run any commands. I reworked these tasks to download files without changing the current directory, often by replacing wget with
curl --create-dirs -o.Was still having some Node version issues when executing the pipeline, but npm rebuild seemed to fix that. I'm not sure if something else could be done to fix that, but putting an
npm rebuildnear the end of the Docker file was enough to solve that problem for me.