add stable order for smoke tests + restoring client codegen #3265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tools/scripts/run_code_generation.py
Outdated
| @@ -155,9 +155,13 @@ def collect_available_models(models_dir: str, endpoint_rules_dir: str, legacy_ma | |||
| with open(models_dir + "/" + model_file_date[0], 'r') as json_file: | |||
| model = json.load(json_file) | |||
| #get service id. It has to exist, else continue | |||
| if ("metadata" in model and "serviceId" in model["metadata"]): | |||
| if ("metadata" in model and (("serviceId" in model["metadata"]) or ("serviceFullName" in model["metadata"])) ): | |||
There was a problem hiding this comment.
this is not according to python pep8 format
There was a problem hiding this comment.
Thanks, will make it more pythonic
|
|
||
| @Override | ||
| public String toString() { | ||
| StringBuilder sb = new StringBuilder(); | ||
|
|
||
| coreHeaders.forEach( | ||
| setToSortedList(coreHeaders).forEach( |
There was a problem hiding this comment.
instead you could just use LinkedHashSet type to avoid an extra sort.
tools/scripts/run_code_generation.py
Outdated
| if key not in legacy_mapped_services: | ||
| key = model["metadata"]["serviceId"] | ||
| if "serviceId" in model["metadata"]: |
There was a problem hiding this comment.
this is not a python-style code.
smth like this
key = model["metadata"].get("serviceId", model["metadata"]["serviceFullName"])
There was a problem hiding this comment.
[] usage is valid here because of key check. I can switch to .get() in this case which is indeed less verbose
sbiscigl
approved these changes
Jan 22, 2025
SergeyRyabinin
approved these changes
Jan 23, 2025
|
Dry run passed [d2de54790974] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Check all that applies:
Check which platforms you have built SDK on to verify the correctness of this PR.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.