feat #11: extend support for database ops via SQL driver #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Closed
ccoVeille
reviewed
Dec 24, 2024
uuidv8.go
Outdated
|
|
||
| // Value implements the driver.Value interface for database writes. | ||
| func (u *UUIDv8) Value() (driver.Value, error) { | ||
| if u == nil || len(u.Node) != 6 { |
There was a problem hiding this comment.
For me the len(u.Node) != 6 should return an error, no?
But maybe I'm wrong
There was a problem hiding this comment.
Makes sense 💯 I've made the validation stricter here.
|
works for me, thanks |
Co-authored-by: ccoVeille <[email protected]>
Co-authored-by: ccoVeille <[email protected]>
Co-authored-by: ccoVeille <[email protected]>
ashwingopalsamy
added a commit
that referenced
this pull request
Jan 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
With this PR, as highlighted in #11, we attempt to extend support for Go Database Drivers to use
UUIDv8in db operations.@vtolstov - Please review and let me know your thoughts.