Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pagination #1587

Merged
merged 4 commits into from
Jan 2, 2025
Merged

Fix pagination #1587

merged 4 commits into from
Jan 2, 2025

Conversation

ItzNotABug
Copy link
Member

What does this PR do?

Fixes pagination on console when using Pink V2.

Test Plan

Manual.

Before -

image

After -

image

Related PRs and Issues

N/A.

Have you read the Contributing Guidelines on issues?

Yes.

@ItzNotABug ItzNotABug requested a review from ernstmul December 30, 2024 13:58
@ItzNotABug ItzNotABug self-assigned this Dec 30, 2024
@ernstmul
Copy link
Contributor

ernstmul commented Jan 2, 2025

Imo I would say remove all the commented stuff. If we find out we do have a need for it after Pink v2 we always have it in GIT versioning. Otherwise this file becomes like 80% commented out code, which we'll probably otherwise never really remove.

@ItzNotABug
Copy link
Member Author

Imo I would say remove all the commented stuff. If we find out we do have a need for it after Pink v2 we always have it in GIT versioning. Otherwise this file becomes like 80% commented out code, which we'll probably otherwise never really remove.

Makes sense. Fixing rq.

@ernstmul ernstmul merged commit fded265 into feat-pink-v2 Jan 2, 2025
0 of 2 checks passed
@ItzNotABug ItzNotABug deleted the fix-pagination branch January 2, 2025 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants