KAFKA-18633: Remove errorUnavailableEndpoints from handleTopicMetadataRequest #18692
+23
−95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
triage
chia7712
reviewed
Jan 24, 2025
github-actions
bot
added
small
chia7712
reviewed
Jan 25, 2025
| @@ -60,42 +60,25 @@ class KRaftMetadataCache( | |||
|
|
|||
| // This method is the main hotspot when it comes to the performance of metadata requests, | |||
| // we should be careful about adding additional logic here. | |||
| // filterUnavailableEndpoints exists to support v0 MetadataResponses | |||
| private def maybeFilterAliveReplicas(image: MetadataImage, | |||
There was a problem hiding this comment.
This method has one-line only, so maybe we can inline this method?
There was a problem hiding this comment.
Sounds fair:)
Done.
|
Let's please not merge this for now. We're considering the possibility of restoring the older metadata versions since that change breaks all released versions of kafka-python. |
yes, let me add link to the jira (https://issues.apache.org/jira/browse/KAFKA-18648) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove
errorUnavailableEndpoints, this is no longer required as the min version of MetadataRequest is v4 so the flag is always false now.Jira: https://issues.apache.org/jira/browse/KAFKA-18633
Committer Checklist (excluded from commit message)