Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HIVE-28693: Upgrade Atlas to 2.4.0 & spring-ldap-core to 2.4.4 #5597

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

basapuram-kumar
Copy link

@basapuram-kumar basapuram-kumar commented Jan 6, 2025

What changes were proposed in this pull request?

Upgrading the Atlas to 2.4.0, details are in-detailed at HIVE-28693

Why are the changes needed?

This change will fix the CVE-2023-20863.
And
Upgrading to Apache Atlas 2.4.0 will not only resolve the vulnerability but also ensure alignment of spriongframework with Apache Hive, which uses Spring Framework 5.3.39. This version of Spring Framework is included transitively by Hive.

Does this PR introduce any user-facing change?

No

Is the change a dependency upgrade?

Yes

How was this patch tested?

Adding the image for packaged jars and the dependency tree for Spring
Screenshot 2025-01-07 at 11 45 39

And complete dependency tree
hive_28693_dependency_tree.log

@Aggarwal-Raghav
Copy link
Contributor

@basapuram-kumar, thanks for PR

  1. please attach dependency tree in the PR temaplate and set Is the change a dependency upgrade? to 'Yes'
  2. During packaging spring-beans 5.3.21 is still coming from spring-ldap-core dependency. Hence, based on your explanation on the JIRA ticket CVE still exists!! If possible, can you check if we can upgrade that as well.

@Aggarwal-Raghav
Copy link
Contributor

I just checked why spring-bean 5.3.21 didn't appear during #5435. Looks like HIVE-28540 was merged during the same time and due to it, screenshot of lib dir and dependency tree attached in #5435 became stale.

@basapuram-kumar
Copy link
Author

Thanks for the review @Aggarwal-Raghav. Sure , will take it up and let you know with requested changes.

Copy link

sonarqubecloud bot commented Jan 7, 2025

@basapuram-kumar
Copy link
Author

Hello @Aggarwal-Raghav ,

Added the suggested one's. Could you please review.

@Aggarwal-Raghav
Copy link
Contributor

I would suggest to change the title of JIRA and commit message to include upgrade spring ldap core as well. Otherwise,

LGTM +1 (non-binding).

@basapuram-kumar basapuram-kumar changed the title HIVE-28693: Upgrade Atlas to 2.4.0 HIVE-28693: Upgrade Atlas to 2.4.0 & spring-ldap-core to 2.4.4 Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants