AG-13839 Single-touch drag (show tooltip) #3411
Open
+568
−61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olegat
requested review from
alantreadway,
rmc-software and
a team
as code owners
|
Snapshots automatically updated, please review before merge: diff |
|
Snapshots automatically updated, please review before merge: diff |
olegat
force-pushed
the
AG-13839/single_touch_drag
branch
from
96d15da to
050522b
Compare
|
Snapshots automatically updated, please review before merge: diff |
olegat
force-pushed
the
AG-13839/single_touch_drag
branch
from
050522b to
9d77a45
Compare
This seems to work as intended on the X-axis. The Y-axis has an issue at the moment (perhaps because the direction of the screen and normalised Y-values is reversed). I'll write up my paper math notes once I've got a working solution.
The two-fingers zoompan gesture on the X-axis was working only if the touch[0] was on the left and touch[1] was on the right. When the positioning of touch[0] and touch[1] was reversed, so too was the gesture. Therefore, ensure that x0 <= x1 and a0 <= a1.
There were two bugs: 1) We don't need to flip the normalised Y value (N - y) 2) We weren't flipping the screen Y value in 'touchstart'
The variable names `f` and `g` look too much like functions instead of variables.
This fixes the 'zoom > navigator' e2e test
olegat
force-pushed
the
AG-13839/single_touch_drag
branch
from
9d77a45 to
df8ce2e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://ag-grid.atlassian.net/browse/AG-13839
Depends on: