Document Windows limitation on usb_midi.set_names(audio_control_interface_name=...) #9946
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jepler
reviewed
Jan 10, 2025
Comment on lines
+200
to
+201
| "ports/analog/msdk", | ||
| "ports/analog/peripherals", |
There was a problem hiding this comment.
this frequently vexes me. perhaps we should explicitly list the documents we want with include_patterns instead (https://www.sphinx-doc.org/en/master/usage/configuration.html#confval-include_patterns)
There was a problem hiding this comment.
I like that idea.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9871.
usb_midi.set_names()prevents the MIDI device from being recognized ifaudio_control_interface_nameis 32 chars or more. We can't check for this because we can't find out the host OS, but it's now documented.I also prevented the doc build from looking inside things in
ports/analogit shouldn't bother to look in.