Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple Python versions from version-file in one environment #647

Closed

Conversation

viccie30
Copy link

This makes the change from #567 also available for users of
.python-version.

@viccie30 viccie30 requested a review from a team as a code owner April 11, 2023 01:58
This makes the change from #567 also available for users of
.python-version.
@viccie30 viccie30 force-pushed the multiple-versions-from-version-file branch from fc4be48 to d59aa9e Compare April 11, 2023 08:23
@gowridurgad
Copy link
Contributor

Hi @viccie30, Thank you for your contribution to the setup-python action!
We appreciate your efforts in proposing this feature. However, we have reviewed the changes and found that they will break when the python-version-file input is set to pyproject.toml. Attached is a screenshot for your reference. According to the official Poetry documentation, the pyproject.toml file only supports specifying a single Python version constraint or range, not multiple discrete versions.
For example:

[tool.poetry.dependencies]
python = ">=3.6,<4.0"

This specifies a range of acceptable Python versions but does not list multiple discrete versions. You can find more details in the official Poetry documentation: Poetry Documentation - Specifying Dependencies.

@gowridurgad gowridurgad self-assigned this Jan 8, 2025
@gowridurgad
Copy link
Contributor

Hi @viccie30,
Just a gentle reminder. Do you have any concerns or updates regarding the previous discussion?

@viccie30
Copy link
Author

Hi @viccie30, Just a gentle reminder. Do you have any concerns or updates regarding the previous discussion?

I don't, mostly because I cannot remember what I was trying to do two years ago, when I opened this pull request. I have not used this action for some 18 months, I think, so feel free to use or discard this as you think best.

@gowridurgad
Copy link
Contributor

Hi @viccie30, Thank you for your response. Since it is not compatible with the official specifications, we will be closing this pull request. If you have any further questions or concerns, please feel free to reach out and encourage you to continue sharing feedback as we strive to improve the action.

@viccie30 viccie30 deleted the multiple-versions-from-version-file branch January 22, 2025 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants