-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changing current site title block logo #68640
base: trunk
Are you sure you want to change the base?
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Thank you for this, I am adding a design review. I agree that having any icon other than the location one right now works for me. My only concern is that discoverability might decrease because people expect now it to be that icon, but we can resolve that with awareness. |
Giving some design feedback. Another idea I just had was the heading icon, but as a outline. |
Thank you, @hanneslsm, for your feedback. I've attached a screenshot of the modified "T" icon for your review. Please have a look and share your thoughts. |
In my opinion, the icon looks unbalanced compared to other text based icons (bold, capitalize, lowercase, uppercase, title, heading levels) because the vertical line is thicker than the horisontal. |
Are there past discussions and decisions saying that the existing title icon can not be used for the site title? |
..If the current text-based icons are based on the same font family, it would be good to use the same, and document it for the future. Who would know if this is the case? @WordPress/gutenberg-design |
Hi @carolinan , Thanks for your suggestions. I have reduced the overall thickness to avoid the icon appearing unbalanced in the latest commit.
Based on the scenarios outlined in this issue, replacing the existing icon seems like a better approach. Here are some points mentioning in the ticket:
More design feedbacks are welcome. Thanks |
I literally meant the title icon, not the current site title icon. |
I don't think it's good practice to use the same icon for two different blocks. |
What?
Fixes #30233
Why?
Current Site Title block logo is confusing.
How?
Changed current icon of site title.
Testing Instructions
Screenshots or screencast