Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing current site title block logo #68640

Open
wants to merge 3 commits into
base: trunk
Choose a base branch
from

Conversation

benazeer-ben
Copy link
Contributor

What?

Fixes #30233

Why?

Current Site Title block logo is confusing.

How?

Changed current icon of site title.

Testing Instructions

  • Go to WP admin.
  • Update or create any post.
  • Add site Title block.
  • Verify the icon change in editor.

Screenshots or screencast

Before After
Screenshot (5)Screenshot (6) Screenshot (7)Screenshot (8)

Copy link

github-actions bot commented Jan 13, 2025

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: benazeer-ben <[email protected]>
Co-authored-by: karmatosed <[email protected]>
Co-authored-by: hanneslsm <[email protected]>
Co-authored-by: carolinan <[email protected]>
Co-authored-by: hedgefield <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@Mamaduka Mamaduka added [Type] Enhancement A suggestion for improvement. [Block] Site Title Affects the Site Title Block labels Jan 13, 2025
@karmatosed karmatosed self-requested a review January 15, 2025 12:55
@karmatosed
Copy link
Member

Thank you for this, I am adding a design review. I agree that having any icon other than the location one right now works for me. My only concern is that discoverability might decrease because people expect now it to be that icon, but we can resolve that with awareness.

@hanneslsm
Copy link

Giving some design feedback.
In general, a T could work as a icon here.
Judging form the screenshot, the strokes looks inconsistent with the other icons, also the edges could get a little of roundness.
@benazeer-ben If you could place your new T icon besides the other already used ones, it'd help to give a give detailed design review.

Another idea I just had was the heading icon, but as a outline.

@benazeer-ben
Copy link
Contributor Author

Thank you, @hanneslsm, for your feedback.

I've attached a screenshot of the modified "T" icon for your review. Please have a look and share your thoughts.

Further suggestions are always welcome!
Screenshot (2)

@carolinan
Copy link
Contributor

In my opinion, the icon looks unbalanced compared to other text based icons (bold, capitalize, lowercase, uppercase, title, heading levels) because the vertical line is thicker than the horisontal.

@carolinan
Copy link
Contributor

Are there past discussions and decisions saying that the existing title icon can not be used for the site title?

@carolinan
Copy link
Contributor

..If the current text-based icons are based on the same font family, it would be good to use the same, and document it for the future. Who would know if this is the case? @WordPress/gutenberg-design

@benazeer-ben
Copy link
Contributor Author

Hi @carolinan , Thanks for your suggestions.

I have reduced the overall thickness to avoid the icon appearing unbalanced in the latest commit.

Are there past discussions and decisions saying that the existing title icon can not be used for the site title?

Based on the scenarios outlined in this issue, replacing the existing icon seems like a better approach.

Here are some points mentioning in the ticket:

Confusing icon - is very similarly to a ‘location’ icon in Google maps.
I guess it doesn't help when you are only glancing over the blocks.

More design feedbacks are welcome.

Thanks

@carolinan
Copy link
Contributor

I literally meant the title icon, not the current site title icon.
https://github.com/WordPress/gutenberg/blob/trunk/packages/icons/src/library/title.js
The one that is used for other titles like the query title: https://github.com/WordPress/gutenberg/blob/trunk/packages/block-library/src/query-title/index.js

@benazeer-ben
Copy link
Contributor Author

Yes, using the existing title is also a good option. I've attached a screenshot for quick reference.

Screenshot (6)

@hanneslsm
Copy link

Yes, using the existing title is also a good option.

I don't think it's good practice to use the same icon for two different blocks.
I made some proposals in the issue. Happy to get some feedback there.

@t-hamano t-hamano added the Needs Design Feedback Needs general design feedback. label Jan 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Site Title Affects the Site Title Block Needs Design Feedback Needs general design feedback. [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feedback: The meaning of the Site Title block icon is not obvious
6 participants