Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #3 First Attempt Complete #15

Merged
merged 11 commits into from
May 2, 2023
Merged

Issue #3 First Attempt Complete #15

merged 11 commits into from
May 2, 2023

Conversation

robecampbelljr
Copy link
Collaborator

Issue #3
Netlify Preview available.
I chose to make this about basic goal setting. The form will allow the user to add a new goals to the goals table along with a checklist where you can add up to three list items as steps for your goal.

@axecopfire
Copy link
Member

Why doesn't the Netlify deploy preview show on the PR? https://docs.netlify.com/site-deploys/deploy-previews/

@robecampbelljr
Copy link
Collaborator Author

https://docs.netlify.com/site-deploys/deploy-previews/

I attempted to follow the instructions on Netlify provided in the issue #3 References section. When I attempted to connect Netlify to the repository, says it must be done by an organization owner.

@axecopfire
Copy link
Member

Interesting, it's enabled for all repos in the org...

@axecopfire
Copy link
Member

test deploy preview

Comment on lines +17 to +19
<a href="./index.html"><li>Home</li></a>
<a href="./about.html"><li>About</li></a>
<a href="#"><li>Contact</li></a>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

li should wrap a

</head>
<body>
<script src="./lib.js"></script>
<div class="app">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is this div here?

<p>Goal setting is the process of defining targets or objectives that one intends to achieve within a specific time frame. <strong>Setting SMART goals</strong>, which are specific, measurable, achievable, relevant, and time-bound, can increase the chances of success. A good starting point is to identify what you want to achieve and why, and then break down the goal into smaller, more manageable steps. <strong>Visualizing success</strong> and regularly reviewing progress can help to stay motivated and focused. Setting goals can lead to a sense of direction and purpose, and <a href="https://en.wikipedia.org/wiki/Motivation">motivate</a> people to work towards their aspirations. It can also promote personal growth and development, improve performance, and increase satisfaction and happiness.</p>
<p>Use the form below to add another goal to the goal list. All fileds will <em>only accept</em> alpha numeric characters with the exception of the description field; it will accept basic punctuation.</p>
</section>
<hr>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<hr /> instead of <hr>

setTable();
</script>
</section>
<br>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<br /> instead of <br>

Robert E. Campbell Jr added 3 commits April 27, 2023 18:35
@robecampbelljr robecampbelljr merged commit ef53a10 into main May 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants