Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: periodic operations to use time.Ticker #978

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

refactor: periodic operations to use time.Ticker #978

wants to merge 1 commit into from

Conversation

appleboy
Copy link
Contributor

  • Use time.Ticker instead of time.After for periodic operations in autoSave function
  • Use time.Ticker instead of time.After for periodic operations in monitor function

Summary

This PR includes the following changes:

  • Replaced time.After(interval) with time.NewTicker(interval) in both storage/store/store.go and watchdog/watchdog.go.
  • This change ensures that the automatic save and monitoring operations are executed regularly and that the ticker is properly stopped when the context is done.

@appleboy
refactor: periodic operations to use time.Ticker
88aecb3 
- Use `time.Ticker` instead of `time.After` for periodic operations in `autoSave` function
- Use `time.Ticker` instead of `time.After` for periodic operations in `monitor` function

Signed-off-by: appleboy <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@igophper igophper igophper approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@appleboy @igophper