Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: useStore without a selector should no longer crash in React #1123

Merged
merged 2 commits into from
Jan 21, 2025

Conversation

crutchcorn
Copy link
Member

Fixes: #1122

Copy link

nx-cloud bot commented Jan 21, 2025

View your CI Pipeline Execution ↗ for commit bdf952a.

Command Status Duration Result
nx affected --targets=test:sherif,test:knip,tes... ✅ Succeeded 1m 17s View ↗
nx run-many --target=build --exclude=examples/** ✅ Succeeded <1s View ↗

☁️ Nx Cloud last updated this comment at 2025-01-21 18:29:35 UTC

Copy link

pkg-pr-new bot commented Jan 21, 2025

Open in Stackblitz

More templates

@tanstack/angular-form

npm i https://pkg.pr.new/@tanstack/angular-form@1123

@tanstack/react-form

npm i https://pkg.pr.new/@tanstack/react-form@1123

@tanstack/lit-form

npm i https://pkg.pr.new/@tanstack/lit-form@1123

@tanstack/solid-form

npm i https://pkg.pr.new/@tanstack/solid-form@1123

@tanstack/valibot-form-adapter

npm i https://pkg.pr.new/@tanstack/valibot-form-adapter@1123

@tanstack/form-core

npm i https://pkg.pr.new/@tanstack/form-core@1123

@tanstack/vue-form

npm i https://pkg.pr.new/@tanstack/vue-form@1123

@tanstack/yup-form-adapter

npm i https://pkg.pr.new/@tanstack/yup-form-adapter@1123

@tanstack/zod-form-adapter

npm i https://pkg.pr.new/@tanstack/zod-form-adapter@1123

commit: bdf952a

Copy link

codecov bot commented Jan 21, 2025

Codecov Report

Attention: Patch coverage is 86.20690% with 8 lines in your changes missing coverage. Please review.

Project coverage is 86.61%. Comparing base (280060a) to head (bdf952a).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
packages/form-core/src/utils.ts 71.42% 4 Missing and 4 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1123      +/-   ##
==========================================
- Coverage   86.70%   86.61%   -0.09%     
==========================================
  Files          29       29              
  Lines        1181     1233      +52     
  Branches      293      329      +36     
==========================================
+ Hits         1024     1068      +44     
- Misses        144      148       +4     
- Partials       13       17       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@crutchcorn crutchcorn merged commit a56d353 into main Jan 21, 2025
6 of 7 checks passed
@crutchcorn crutchcorn deleted the fix-use-store-no-selector branch January 21, 2025 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UseStore - Maximum update depth exceeded when selector is not present
1 participant