Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creates a log viewer #89

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

Creates a log viewer #89

wants to merge 11 commits into from

Conversation

vishnuravi
Copy link
Member

@vishnuravi vishnuravi commented Nov 10, 2024

Creates a log viewer

♻️ Current situation & Problem

Currently there is no mechanism within the application itself to view or share application logs for debugging purposes. This makes it challenging to address issues occurring on remote users' devices that cannot be readily attached to a debugger.

⚙️ Release Notes

  • Creates a log viewer to show application logs
  • Allows filtering by date and log level (e.g. info, debug, error, notice)
  • Allow sharing log data using the share sheet
  • Log viewer can be accessed from the account view

Screenshot

📚 Documentation

Inline documentation added.

✅ Testing

UI tests added.

📝 Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

Copy link

codecov bot commented Nov 10, 2024

Codecov Report

Attention: Patch coverage is 54.30712% with 122 lines in your changes missing coverage. Please review.

Project coverage is 77.81%. Comparing base (fed2d72) to head (bf23aae).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
TemplateApplication/Logging/LogLevel.swift 25.50% 38 Missing ⚠️
TemplateApplication/Logging/LogViewer.swift 77.78% 28 Missing ⚠️
TemplateApplication/Logging/LogsListView.swift 18.19% 27 Missing ⚠️
TemplateApplication/Logging/LogManager.swift 59.46% 15 Missing ⚠️
TemplateApplication/Logging/LogManagerError.swift 0.00% 8 Missing ⚠️
...ion/Logging/OSLogEntryLog+FormattedLogOutput.swift 0.00% 6 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #89      +/-   ##
==========================================
- Coverage   86.92%   77.81%   -9.11%     
==========================================
  Files          21       27       +6     
  Lines         688      955     +267     
==========================================
+ Hits          598      743     +145     
- Misses         90      212     +122     
Files with missing lines Coverage Δ
TemplateApplication/Account/AccountSheet.swift 74.42% <100.00%> (+4.15%) ⬆️
...ion/Logging/OSLogEntryLog+FormattedLogOutput.swift 0.00% <0.00%> (ø)
TemplateApplication/Logging/LogManagerError.swift 0.00% <0.00%> (ø)
TemplateApplication/Logging/LogManager.swift 59.46% <59.46%> (ø)
TemplateApplication/Logging/LogsListView.swift 18.19% <18.19%> (ø)
TemplateApplication/Logging/LogViewer.swift 77.78% <77.78%> (ø)
TemplateApplication/Logging/LogLevel.swift 25.50% <25.50%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ea08d6d...bf23aae. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant