Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix indexer offset for post positioning methods #301

Merged
merged 1 commit into from
Sep 27, 2022
Merged

Conversation

JimBobSquarePants
Copy link
Member

@JimBobSquarePants JimBobSquarePants commented Sep 27, 2022

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following matches the existing coding patterns and practice as demonstrated in the repository. These follow strict Stylecop rules 👮.
  • I have provided test coverage for my change (where applicable)

Description

We were failing to offset the lookups for fixing up cursive and mark attachments. Fixes #300

Test ดวันโอวัน
ดวันโอวัน

@codecov
Copy link

codecov bot commented Sep 27, 2022

Codecov Report

Merging #301 (c0ae03e) into main (ca3231c) will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff          @@
##            main    #301   +/-   ##
=====================================
  Coverage     83%     83%           
=====================================
  Files        222     222           
  Lines      12276   12276           
  Branches    1781    1781           
=====================================
  Hits       10253   10253           
  Misses      1591    1591           
  Partials     432     432           
Flag Coverage Δ
unittests 83% <100%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...bors.Fonts/Tables/AdvancedTypographic/GPosTable.cs 84% <100%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@JimBobSquarePants JimBobSquarePants merged commit 5d75771 into main Sep 27, 2022
@JimBobSquarePants JimBobSquarePants deleted the js/fix-300 branch September 27, 2022 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect render of Thai characters when ascii characters are present in rendered text
2 participants