-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add test for enabling Safari browser logging in JavaScript #2127
base: trunk
Are you sure you want to change the base?
Conversation
👷 Deploy request for selenium-dev pending review.Visit the deploys page to approve it
|
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨Explore these optional code suggestions:
|
}); | ||
|
||
describe('Should be able to enable Safari logging', function () { | ||
this.timeout(15000); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why we need timeout in here ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And i don't think this is the right example , Can you check again!
User description
This PR introduces a new JavaScript test to validate the functionality of enabling browser-level logging in Safari. Key updates include:
setLoggingPrefs
to enable logging for the Safari browser.This enhancement ensures proper validation of Safari's logging capabilities and improves test coverage for Safari-specific features.
Tests are passing locally.
PR Type
Tests, Documentation
Description
Added a new JavaScript test for enabling Safari browser logging.
Updated Safari documentation with a JavaScript example for logging.
Enhanced test coverage for Safari-specific features.
Improved multilingual documentation for Safari logging in JavaScript.
Changes walkthrough 📝
safariSpecificCap.spec.js
Add Safari logging test in JavaScript
examples/javascript/test/browser/safariSpecificCap.spec.js
setLoggingPrefs
for browser-level logging.safari.en.md
Update Safari documentation with JavaScript example
website_and_docs/content/documentation/webdriver/browsers/safari.en.md
safari.ja.md
Update Japanese Safari documentation with JavaScript example
website_and_docs/content/documentation/webdriver/browsers/safari.ja.md
safari.pt-br.md
Update Portuguese Safari documentation with JavaScript example
website_and_docs/content/documentation/webdriver/browsers/safari.pt-br.md