Allow sending DevTools command with custom timeout.

[dennisoelkers]

Description

This PR is introducing an additional method (DevTools#sendWithTimeout) that allows consumers to send a DevTools command with a custom timeout instead of the hardcoded one.

Motivation and Context

Some commands send oder CDP can take longer than the hardcoded timeout, e.g. printing a page to PDF. This might happen due to excessive work in the controller browser or during serialization/transmission. For cases like this, DevTools#sendWithTimeout can be used to use a higher timeout for these exceptional cases.

Fixes #14912.

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist

• I have read the contributing document.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have added tests to cover my changes.
• All new and existing tests passed.

---

PR Type

Enhancement

---

Description

• Introduced sendWithTimeout method for custom timeout in DevTools commands.

• Refactored send method to utilize sendWithTimeout internally.

• Improved flexibility for handling long-running DevTools commands.

---

Changes walkthrough 📝

	Relevant files
Enhancement	DevTools.java Add `sendWithTimeout` method for configurable timeouts      java/src/org/openqa/selenium/devtools/DevTools.java Added sendWithTimeout method for sending commands with a custom timeout. Refactored send method to delegate to sendWithTimeout. Ensured non-null validation for commands in sendWithTimeout. +6/-2

---

💡 PR-Agent usage: Comment /help "your question" on any pull request to receive relevant information

[qodo-merge-pro]

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪

🧪 No relevant tests

🔒 No security concerns identified

⚡ Recommended focus areas for review Parameter Validation The timeout parameter in sendWithTimeout() should be validated to ensure it's not null or negative to prevent potential runtime issues public <X> X sendWithTimeout(Command<X> command, Duration timeout) { Require.nonNull("Command to send", command); return connection.sendAndWait(cdpSession, command, timeout); }

[qodo-merge-pro]

PR Code Suggestions ✨

Explore these optional code suggestions:

Category	Suggestion	Score
Possible issue	Add session state validation to prevent null pointer exceptions Add validation to ensure cdpSession is not null before sending commands to prevent NullPointerException. java/src/org/openqa/selenium/devtools/DevTools.java [72-75] public <X> X sendWithTimeout(Command<X> command, Duration timeout) { Require.nonNull("Command to send", command); + Require.state(cdpSession != null, "CDP session is not active"); return connection.sendAndWait(cdpSession, command, timeout); } Apply this suggestion Suggestion importance[1-10]: 9 Why: This suggestion addresses a critical potential null pointer vulnerability by validating the CDP session state before execution. Given that cdpSession is nullable (as seen in disconnectSession), this validation is essential for preventing runtime crashes.	9
	Add input validation for timeout parameter to prevent invalid duration values Add validation to ensure the timeout parameter is positive and non-null to prevent potential issues with negative or null timeouts. java/src/org/openqa/selenium/devtools/DevTools.java [72-75] public <X> X sendWithTimeout(Command<X> command, Duration timeout) { Require.nonNull("Command to send", command); + Require.nonNull("Timeout duration", timeout); + Require.positive("Timeout duration", timeout.toMillis()); return connection.sendAndWait(cdpSession, command, timeout); } Apply this suggestion Suggestion importance[1-10]: 8 Why: Adding validation for the timeout parameter is crucial for preventing runtime errors and ensuring proper function behavior. The suggestion adds comprehensive checks for null and negative values, which are essential for a parameter that controls execution timing.	8

[diemol]

Let's just name it send.

[shbenzer]

@diemol do we need to add a test for this?

[diemol]

I don't see the need for it. What do you think?

[shbenzer]

I don't see the need for it. What do you think?

After taking another look, I don't think so. I didn't realize sendWithTimeout() was just a wrapper for sendAndWait()