-
-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[py] Upgraded WebDriverWait Docstrings #15054
base: trunk
Are you sure you want to change the base?
Conversation
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨Explore these optional code suggestions:
|
extra liting done This reverts commit 32214b6.
@diemol should be good to go now |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## trunk #15054 +/- ##
=======================================
Coverage 58.61% 58.61%
=======================================
Files 94 94
Lines 5998 5998
Branches 259 259
=======================================
Hits 3516 3516
Misses 2223 2223
Partials 259 259 ☔ View full report in Codecov by Sentry. |
@AutomatedTester should work now |
one of the packages format.sh used needed to be reinstalled |
User description
Description
improved the docstrings of the WebDriverWait class and its methods
Motivation and Context
improves documentation and better informs users
Types of changes
Checklist
PR Type
Documentation
Description
Enhanced docstrings for
WebDriverWait
class and methods.Improved parameter descriptions with detailed explanations.
Added examples for better understanding of usage.
Updated formatting for consistency and clarity.
Changes walkthrough 📝
wait.py
Enhanced docstrings for `WebDriverWait` class methods
py/selenium/webdriver/support/wait.py
__init__
,until
, anduntil_not
methods.