-
-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[py] Update supported Python versions 3.9+ #15018
base: trunk
Are you sure you want to change the base?
Conversation
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨Explore these optional code suggestions:
|
Signed-off-by: Viet Nguyen Duc <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You also need to bump in
Lines 112 to 115 in ee8c6f4
python.toolchain( | |
is_default = True, | |
python_version = "3.8", | |
) |
@AutomatedTester What is our approach to EOL Python versions? |
CI Failure Feedback 🧐(Checks updated until commit 326109c)
|
Signed-off-by: Viet Nguyen Duc <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, but please double check with David on Slack before merge.
User description
Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it
Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.
Description
Following https://endoflife.date/python, https://devguide.python.org/versions/#versions
Python 3.8 ended Security Support on Oct-7, 2024.
Update supported Python versions 3.9+.
Motivation and Context
Types of changes
Checklist
PR Type
Enhancement, Documentation
Description
Dropped support for Python 3.8 across the project.
Updated minimum required Python version to 3.9.
Adjusted documentation to reflect updated Python support.
Updated configuration files to align with new Python version requirements.
Changes walkthrough 📝
BUILD.bazel
Update supported Python versions in Bazel build file
py/BUILD.bazel
python_requires
to require Python 3.9 or higher.pyproject.toml
Adjust Python version requirements in pyproject.toml
py/pyproject.toml
requires-python
to~=3.9
.index.rst
Update documentation for supported Python versions
py/docs/source/index.rst
tox.ini
Update tox configuration for Python 3.9+
py/tox.ini
flake8
configuration to require Python 3.9 or higher.