Merge pull request #883 from ScrapeGraphAI/main

[VinciGit00]

Main differences:

[github-actions]

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

Package	Version	Score	Details

Scanned Files

[codebeaver-ai]

I added some Unit Tests (average coverage improvement: +33.04%). Check it out here to merge it!

[codebeaver-ai]

No files changed in the PR

[VinciGit00]

I also run pre commit on the whole dir for

[codebeaver-ai]

I added some Unit Tests (average coverage improvement: +50.00%). Check it out here to merge it!

[silgon]

I'm just wondering, is there a reason not to use keyword arguments?
I believe you could have more understandable code, or at least not as many if elses as in the following picture.

The example would be:

def search_on_web(
    query: str,
    search_engine: str = "Google",
    max_results: int = 10,
    port: int = 8080,
    timeout: int = 10,
    proxy: str | dict = None,
    serper_api_key: str = None,
    **kwargs
) -> List[str]:
...
 google_search(
                        query,
                        num_results=max_results,
                        proxy=formatted_proxy,
                        **kwargs
                    )

You probably have a reason, you can just ignore this comment in any case. Thx again for the great package =)

[VinciGit00]

This is the definition fo the search function from google_search library.

As you can see is not present the default region

[codebeaver-ai]

I added some Unit Tests (average coverage improvement: +50.00%). Check it out here to merge it!

[silgon]

I see what you mean @VinciGit00 , however if your parameters are in the dictionary of parameters, there are going to be filled with the ** operator. Example:

def display_info(name, age):
    print(f"Name: {name}, Age: {age}")

person_info = {
    'name': 'Alice',
    'age': 30
}

display_info(**person_info)

[VinciGit00]

@silgon take a look now

[codebeaver-ai]

I added some Unit Tests (average coverage improvement: +50.00%). Check it out here to merge it!

[silgon]

Nice! 😎