[record-hessian] Introduce RecordHessian.

[BLee-bot]

This introduces a part of RecordHessian.

ONE-DCO-1.0-Signed-off-by: Banseok Lee [email protected]

Related Issue : #13480
Draft PR: #13585

[seanshpark]

will continue review after #14297 #14298 lands and this PR is rebased on that.

[seanshpark]

Your current commit title/message is

[record-hessian] This commit introduce record hessian.
This commit introduce record hessian.

which doesn't seem to express current changes.
1/ please fix the title/comment to represent current changes
2/ there are "update" changes and "add" changes. plz split them to separate PRs.

[BLee-bot]

Your current commit title/message is

[record-hessian] This commit introduce record hessian.
This commit introduce record hessian.

which doesn't seem to express current changes. 1/ please fix the title/comment to represent current changes 2/ there are "update" changes and "add" changes. plz split them to separate PRs.

@seanshpark I tried splitting the code into smaller parts, but nncc-common does not allow me to compile if there are unused variables or unimplemented functions. So, could you review my code in this form?

[seanshpark]

if there are unused variables or unimplemented functions

you can solve this.

[seanshpark]

you have useless header file and uncalled methods.
start with adding RecordHessian::initialize()

[BLee-bot]

you have useless header file and uncalled methods. start with adding RecordHessian::initialize()

I split the code. That method will be implemented in later PR!
will update to remove useless headers at this time.

//namespace record_hessian
//{
//void RecordHessian::initialize(luci::Module *module); // To Be Implemented
// std::unique_ptr RecordHessian::profileData(const std::string &input_data_path); // To Be Implemented
//} namespace record_hessian

[BLee-bot]

@seanshpark I've modified the way what you said. PTAL:)

you have useless header file and uncalled methods. start with adding RecordHessian::initialize()

[seanshpark]

I've modified the way what you said.

What I expect start with adding RecordHessian::initialize() is like header with

class RecordHessian
{
public:
  RecordHessian() {}

  void initialize(luci::Module *module);
}

and cpp with implementation. Your code is as-is two weeks before without any change.

[BLee-bot]

I've modified the way what you said.

What I expect start with adding RecordHessian::initialize() is like header with

class RecordHessian
{
public:
  RecordHessian() {}

  void initialize(luci::Module *module);
}

and cpp with implementation. Your code is as-is two weeks before without any change.

I thought I should start by sharing small parts of the code and waited for a review. However, I understood that I should share it based on the bigger parts(e.g. initialize), so I uploaded the code accordingly.

[seanshpark]

is there particular reason to use local variable for creation and move to members?

[BLee-bot]

These two lines of code was added to implement profileData with multithreading, but it seems redundant now, so it would be better to remove it.

[BLee-bot]

@seanshpark I've modified the way what you said. PTAL:)