-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve the Extend::extend
implementation for performances
#306
Conversation
RoaringBitmap::insert_many
method
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code seems right to me. It could execute way quickly if the iterator was sorted, but I guess that can wait until we need it 😅
My only concerns is that, from what I understand, this function is exactly matching the API of the Extend
trait.
Shouldn't we implement that trait instead of making our own function?
RoaringBitmap::insert_many
methodExtend::extend
implementation for performances
You are absolutely right that the Thank you 🙏 |
fb164b9
to
4dfd47b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One last smol change and we can merge!
4dfd47b
to
d5dca9a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfecto 👌
Fixes #301.