New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(windows): fixing tests on windows #752

Open

ggodik wants to merge 2 commits into RichardKnop:master from ggodik:gg/win-fix

ggodik commented Apr 4, 2022 •

edited

Loading

Found a few windows specific unit test issues

config.TestReadFromFile breaks because windows reads in carriage returns and the hardcoded string does not have these. Fixed by making test content on the fly.
util.GetLockName failes because the expected output does not contain a file with .exe extension. Fixed by removing .exe on Windows
moved magic file length constant 1000 to ConfigMaxSize

ggodik added 2 commits

April 4, 2022 16:53


          fix(windows): fixing tests on windows

f2b68e7


          fix(windows): removing windows specific code

c57ceed

rkoehl05 approved these changes

View reviewed changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet