Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: clarify use of emojis in useStylesScoped$ #7257

Merged
merged 1 commit into from
Jan 15, 2025

Conversation

Shane-Donlon
Copy link
Contributor

What is it?

  • Docs

Description

Hi Everyone.

Little bit of background on this PR.

In Discord the question was raised "what does the star icon represent when inspecting the DOM?"

See link: https://discord.com/channels/842438759945601056/1326121240074780722

This emoji is in the process of being updated from start to a lightening bolt.
See PR: #7248

I have tried to update the docs to futureproof this change by not referencing the specific emoji.
But may need to update this after the release in which the icon has changed.

Also as a note: there is a star reference in the docs that will need to be updated after the icon has changed.
Quote:
".list.⭐️8vzca0-0 > *:nth-child(3)"

Have a great day everyone.

Checklist

  • I made corresponding changes to the Qwik docs

@Shane-Donlon Shane-Donlon requested a review from a team as a code owner January 15, 2025 13:33
Copy link

changeset-bot bot commented Jan 15, 2025

⚠️ No Changeset found

Latest commit: fe0f19a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Member

@gioboa gioboa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Shane-Donlon
it looks great to me

Copy link
Contributor

github-actions bot commented Jan 15, 2025

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
qwik-docs ✅ Ready (View Log) Visit Preview fe0f19a

@gioboa gioboa merged commit 122f2a8 into QwikDev:main Jan 15, 2025
14 checks passed
@Shane-Donlon
Copy link
Contributor Author

Thanks @Shane-Donlon
it looks great to me

And no edits!!! 😂😂🎉🎉🥳🥳
Grazie!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants