Makie table extension #24
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+56
to
+63
| Base.Experimental.register_error_hint(MethodError) do io, exc, argtypes, kwargs | ||
| if exc.f === makie_table! | ||
| if isempty(methods(exc.f)) | ||
| print(io, "\n$(exc.f) has no methods, yet. Makie has to be loaded for the table extension to be activated. Run `using Makie`, `using CairoMakie`, `using GLMakie` or any other package that also loads Makie.") | ||
| end | ||
| end | ||
| end | ||
| end |
There was a problem hiding this comment.
Would it be more straightforward to just define an ::Any method on makie_table! that prints out this message rather than doing an error hint?
There was a problem hiding this comment.
I had a fallback version with args... first and then removed that again for this, I don't remember my rationale though
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows to place tables into Makie figures looking something like this: