Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update init() type (#1616) #1617

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

thexeos
Copy link

@thexeos thexeos commented Dec 18, 2024

Changes

  • PostHog.init()'s TypeScript signature changed from PostHog | undefined to just PostHog

Copy link

vercel bot commented Dec 18, 2024

@thexeos is attempting to deploy a commit to the PostHog Team on Vercel.

A member of the Team first needs to authorize it.

@posthog-bot
Copy link
Collaborator

This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the stale label – otherwise this will be closed in another week.

@thexeos
Copy link
Author

thexeos commented Dec 25, 2024

Keep open

@posthog-bot posthog-bot removed the stale label Dec 26, 2024
Copy link

vercel bot commented Dec 27, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
posthog-js ✅ Ready (Inspect) Visit Preview Jan 24, 2025 7:46pm

@posthog-bot
Copy link
Collaborator

This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the stale label – otherwise this will be closed in another week.

@thexeos
Copy link
Author

thexeos commented Jan 4, 2025

Keep open

@posthog-bot posthog-bot removed the stale label Jan 6, 2025
@posthog-bot
Copy link
Collaborator

This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the stale label – otherwise this will be closed in another week.

@thexeos
Copy link
Author

thexeos commented Jan 13, 2025

Keep open

@posthog-bot posthog-bot removed the stale label Jan 14, 2025
@posthog-bot
Copy link
Collaborator

This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the stale label – otherwise this will be closed in another week.

@thexeos
Copy link
Author

thexeos commented Jan 21, 2025

Keep open

@posthog-bot posthog-bot removed the stale label Jan 22, 2025
@rafaeelaudibert rafaeelaudibert self-requested a review January 22, 2025 15:45
@rafaeelaudibert
Copy link
Member

@thexeos Sorry for the long delay here. Can you rebase this on master? CI is acting all weird in this PR

@thexeos
Copy link
Author

thexeos commented Jan 23, 2025

@rafaeelaudibert I've rebased the commit

@rafaeelaudibert
Copy link
Member

@thexeos Thank you, I'm working on fixing CI, it's not happy with an external contributor, but we'll sort this out

@rafaeelaudibert rafaeelaudibert added the bump minor Bump minor version when this PR gets merged label Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bump minor Bump minor version when this PR gets merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants