[CSHARP] Default headers overwritten instead of duplicated | Body par…

[maciejcymanski132]

@mandrean @shibayan @Blackclaws

Hello,

I fixed two issues I ran into recently.

First, when both the default configuration and the request options added the same header (like Authorization), the header was duplicated. Now, the request options override the default headers so that the header only appears once.

Second, there was a problem with how POST request bodies were being serialized. They were missing quotes and other formatting details, causing errors on the server. I’ve updated the serialization process to ensure the body is formatted correctly.

Please let me know if you need any changes.

PR checklist

• Read the contribution guidelines.
• Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
• Run the following to build the project and update samples:

  ./mvnw clean package || exit
  ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
  ./bin/utils/export_docs_generators.sh || exit
  

  (For Windows users, please run the script in Git BASH)
  Commit all changed files.
  This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
  These must match the expectations made by your contribution.
  You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
  IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
• [ x] File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
• [ x] If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

[BryanAldrich]

Just FYI, running on a windows environment causes the \ and / differences as well as line ending changes which the build bot notices. I had to run my builds in a WSL environment which made the changes much cleaner.

[wing328]

i've flied #20415 with updated samples.

let's see if all the tests pass

[wing328]

https://github.com/OpenAPITools/openapi-generator/actions/runs/12668462049/job/35310177390

CI tests with updated samples failed - particularly for .net standard 2.0 samples.

@maciejcymanski132 can you please take a look when you've time?

UPDATE: the CI test failure has nothing to do with this PR. I address it in #20421 instead.

[wing328]

Second, there was a problem with how POST request bodies were being serialized. They were missing quotes and other formatting details, causing errors on the server. I’ve updated the serialization process to ensure the body is formatted correctly.

can you please elaborate on the issue with examples?

[wing328]

FYI. Merged #20421 to fix the duplicated header issue

[wing328]

Second, there was a problem with how POST request bodies were being serialized. They were missing quotes and other formatting details, causing errors on the server. I’ve updated the serialization process to ensure the body is formatted correctly.

FYI. We do have integration tests in-place to ensure the POST with request body (e.g. Pet) works: https://github.com/OpenAPITools/openapi-generator/blob/master/samples/client/petstore/csharp/restsharp/standard2.0/Petstore/src/Org.OpenAPITools.Test/Api/PetApiTests.cs#L222

[wing328]

it's serialized later in ApiClient.cs for "JSON" related payload:

openapi-generator/modules/openapi-generator/src/main/resources/csharp/ApiClient.mustache

Line 157 in 4e24cf5

contentType.Value.EndsWith("json", StringComparison.InvariantCultureIgnoreCase) ||

does your content type ends with json?