Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

svg2tikz: 3.2.0 -> 3.3.0 #373213

Merged
merged 1 commit into from
Jan 12, 2025
Merged

svg2tikz: 3.2.0 -> 3.3.0 #373213

merged 1 commit into from
Jan 12, 2025

Conversation

r-ryantm
Copy link
Contributor

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.

  • WARNING: Package has meta.broken=true; Please manually test this package update and remove the broken attribute.

meta.description for svg2tikz is: Set of tools for converting SVG graphics to TikZ/PGF code

meta.homepage for svg2tikz is: https://github.com/xyz2tex/svg2tikz

meta.changelog for svg2tikz is: https://github.com/xyz2tex/svg2tikz/blob/refs/tags/v3.3.0/CHANGELOG.md

Updates performed
  • Ran passthru.UpdateScript
To inspect upstream changes
Impact

Checks done


  • built on NixOS
  • The tests defined in passthru.tests, if any, passed
  • found 3.3.0 with grep in /nix/store/vygx1jz65pxxp7rl3pni7zz7yckq7slr-python3.12-svg2tikz-3.3.0
  • found 3.3.0 in filename of file in /nix/store/vygx1jz65pxxp7rl3pni7zz7yckq7slr-python3.12-svg2tikz-3.3.0

Rebuild report (if merged into master) (click to expand)
4 total rebuild path(s)

4 package rebuild(s)

First fifty rebuilds by attrpath

python312Packages.svg2tikz
python313Packages.svg2tikz
svg2tikz
Instructions to test this update (click to expand)

Either download from the cache:

nix-store -r /nix/store/vygx1jz65pxxp7rl3pni7zz7yckq7slr-python3.12-svg2tikz-3.3.0 \
  --option binary-caches 'https://cache.nixos.org/ https://nixpkgs-update-cache.nix-community.org/' \
  --option trusted-public-keys '
  nixpkgs-update-cache.nix-community.org-1:U8d6wiQecHUPJFSqHN9GSSmNkmdiFW7GW7WNAnHW0SM=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The nixpkgs-update cache is only trusted for this store-path realization.)
For the cached download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.

Or, build yourself:

nix-build -A svg2tikz https://github.com/r-ryantm/nixpkgs/archive/e57a2f292130b67a815019112d38018731df3b5c.tar.gz

Or:

nix build github:r-ryantm/nixpkgs/e57a2f292130b67a815019112d38018731df3b5c#svg2tikz

After you've downloaded or built it, look at the files and if there are any, run the binaries:

ls -la /nix/store/vygx1jz65pxxp7rl3pni7zz7yckq7slr-python3.12-svg2tikz-3.3.0
ls -la /nix/store/vygx1jz65pxxp7rl3pni7zz7yckq7slr-python3.12-svg2tikz-3.3.0/bin


Pre-merge build results

We have automatically built all packages that will get rebuilt due to
this change.

This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review


x86_64-linux

⏩ 6 packages marked as broken and skipped:
  • python312Packages.svg2tikz
  • python312Packages.svg2tikz.dist
  • python313Packages.svg2tikz
  • python313Packages.svg2tikz.dist
  • svg2tikz
  • svg2tikz.dist

Maintainer pings

cc @dotlambda @FlorentBecker for testing.

Tip

As a maintainer, if your package is located under pkgs/by-name/*, you can comment @NixOS/nixpkgs-merge-bot merge to automatically merge this update using the nixpkgs-merge-bot.


Add a 👍 reaction to pull requests you find important.

@NickCao NickCao merged commit 633bf1c into NixOS:master Jan 12, 2025
22 checks passed
@dotlambda
Copy link
Member

Did you check whether it's still broken?

@NickCao
Copy link
Member

NickCao commented Jan 12, 2025

Did you check whether it's still broken?

Nope.

@dotlambda
Copy link
Member

dotlambda commented Jan 12, 2025

Did you check whether it's still broken?

Nope.

So why would you merge something where nixpkgs-review reports no rebuilds?

@NickCao
Copy link
Member

NickCao commented Jan 12, 2025

So why would you merge something where nixpkgs-review reports no rebuilds?

I always review upstream changes, and they look good to me.

@r-ryantm r-ryantm deleted the auto-update/svg2tikz branch January 13, 2025 00:19
@dotlambda
Copy link
Member

I always review upstream changes, and they look good to me.

And the changelog even states that it now works with the newest version of Inkscape, so svg2tikz should no longer be marked broken.
I fix your oversight in #374170.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants