Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/komga: fix settings option and default #373211

Merged
merged 1 commit into from
Jan 12, 2025
Merged

nixos/komga: fix settings option and default #373211

merged 1 commit into from
Jan 12, 2025

Conversation

eclairevoyant
Copy link
Contributor

@eclairevoyant eclairevoyant commented Jan 12, 2025 •
edited
Loading

Use freeform submodule to make default visible in search and prevent the warning about the old option format being used. See #345594 (comment)

It also allows type-checking this value properly, since it's going to be used to open the firewall as well.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Jan 12, 2025
@eclairevoyant
nixos/komga: fix settings option and default
5abcff7 
Use freeform submodule to make default visible in search and
prevent the warning about the old option format being used.
See NixOS#345594 (comment)
@eclairevoyant eclairevoyant marked this pull request as ready for review January 12, 2025 15:04
@eclairevoyant eclairevoyant mentioned this pull request Jan 12, 2025
Merged
13 tasks
@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Jan 12, 2025
ambroisie
ambroisie approved these changes Jan 12, 2025
View reviewed changes
Copy link
Contributor

@ambroisie ambroisie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for missing that one, I don't use that option.

LGTM.

@ambroisie ambroisie merged commit 96be65a into NixOS:master Jan 12, 2025
34 checks passed
@eclairevoyant eclairevoyant deleted the komga-settings-fix branch January 12, 2025 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ambroisie ambroisie ambroisie approved these changes

Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eclairevoyant @ambroisie