sile: fix strictDeps build #373209
sile: fix strictDeps build #373209
Conversation
There was a problem hiding this comment.
LGTM. I wonder what @alerque would think about this, and what would they think of the lack of cross compilation support.
wegank
added
12.approvals: 1
|
Isn't anything in As for cross compilation, it isn't something I've tested upstream yet. I had reports (from Void packagers?) that they had it working with a patch that I added a couple of versions back, but I haven't actually done any cross building myself yet. It's certainly something I'd like to see working. |
|
No, only the nativeBuildInputs get added to $PATH (if strictDeps is enabled). Which is relevant here since it looks for Lua in PATH by default. |
There was a problem hiding this comment.
@alerque don't forget to also update the upstream expression.
| @@ -45,6 +45,7 @@ stdenv.mkDerivation (finalAttrs: { | |||
| nativeBuildInputs = [ | |||
| zstd | |||
| pkg-config | |||
| fontconfig # fc-match | |||
There was a problem hiding this comment.
I tested locally, and reached the conclusion that fontconfig can (and therefor should?) be removed from buildInputs.
| @@ -101,6 +102,7 @@ stdenv.mkDerivation (finalAttrs: { | |||
| gentium | |||
| ]; | |||
| }; | |||
| env.LUA = "${finalAttrs.finalPackage.passthru.luaEnv}/bin/lua"; | |||
There was a problem hiding this comment.
Maybe we can add strictDeps here, no matter what is Nixpkgs' default.
Can you reference us to that patch? I suspect that the way Lua packages are tested for existence in the lua environment is what makes this fail (at least nowadays). |
ref. #178468
Cross-build unfortunately still broken due to build-time Lua detection stuff.
Things done