texmacs: Use LLVM 17 on Darwin

[lions-tech]

The current nixos-unstable branches uses Clang 19.1.5 on Darwin per default. This results in compilation error
"/tmp/nix-build-texmacs-2.1.4.drv-0/TeXmacs/src/Kernel/Containers/hashtree.cpp:97:14: error: no member named 'contains' in 'hashtree<K, V>'".

Things done

Use LLVM 17 on Darwin to build TeXMacs, reason above.

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

Package maintainer: @roconnor

---

Add a 👍 reaction to pull requests you find important.

[paparodeo]

should try not to pin -- not much uses llvm17 and it is broken on aarch64-linux currently and hopefully will be dropped in the near future.

newer llvms will detect broken code in dead code which appears what is happening here. the solution is just to delete the function as it is not used or to fix the code.

remove unused broken code

diff --git a/src/Kernel/Containers/hashtree.cpp b/src/Kernel/Containers/hashtree.cpp
index 300b175..2744d75 100644
--- a/src/Kernel/Containers/hashtree.cpp
+++ b/src/Kernel/Containers/hashtree.cpp
@@ -92,12 +92,6 @@ hashtree<K,V>::operator-> (void) {
   return rep;
 }
 
-template<class K, class V> inline hashtree<K,V> 
-hashtree<K,V>::operator[] (K key) {
-  if (*this->contains (key)) return *this->children (key);
-  else FAILED ("read-access to non-existent node requested");
-}
-  
 template<class K, class V> inline hashtree<K,V> 
 hashtree<K,V>::operator() (K key) {
   realize ();

alternatively, can fix the code though given it was previously broken there are no paths which use this and is therefore untested

fix broken function

diff --git a/src/Kernel/Containers/hashtree.cpp b/src/Kernel/Containers/hashtree.cpp
index 300b175..a36ffb4 100644
--- a/src/Kernel/Containers/hashtree.cpp
+++ b/src/Kernel/Containers/hashtree.cpp
@@ -94,7 +94,7 @@ hashtree<K,V>::operator-> (void) {
 
 template<class K, class V> inline hashtree<K,V> 
 hashtree<K,V>::operator[] (K key) {
-  if (*this->contains (key)) return *this->children (key);
+  if ((*this)->contains (key)) return (*this)->children (key);
   else FAILED ("read-access to non-existent node requested");
 }
   

fix texmacs package

diff --git a/pkgs/applications/editors/texmacs/default.nix b/pkgs/applications/editors/texmacs/default.nix
index 329c0f5a8893..4d5441d2a257 100644
--- a/pkgs/applications/editors/texmacs/default.nix
+++ b/pkgs/applications/editors/texmacs/default.nix
@@ -48,6 +48,10 @@ stdenv.mkDerivation {
     hash = "sha256-h6aSLuDdrAtVzOnNVPqMEWX9WLDHtkCjPy9JXWnBgYY=";
   };
 
+  patches = [
+    ./no-contains.diff
+  ];
+
   postPatch =
     common.postPatch
     + ''
diff --git a/pkgs/applications/editors/texmacs/no-contains.diff b/pkgs/applications/editors/texmacs/no-contains.diff
new file mode 100644
index 000000000000..0ee7e3dd3fab
--- /dev/null
+++ b/pkgs/applications/editors/texmacs/no-contains.diff
@@ -0,0 +1,17 @@
+diff --git a/src/Kernel/Containers/hashtree.cpp b/src/Kernel/Containers/hashtree.cpp
+index 300b175..2744d75 100644
+--- a/src/Kernel/Containers/hashtree.cpp
++++ b/src/Kernel/Containers/hashtree.cpp
+@@ -92,12 +92,6 @@ hashtree<K,V>::operator-> (void) {
+   return rep;
+ }
+ 
+-template<class K, class V> inline hashtree<K,V> 
+-hashtree<K,V>::operator[] (K key) {
+-  if (*this->contains (key)) return *this->children (key);
+-  else FAILED ("read-access to non-existent node requested");
+-}
+-  
+ template<class K, class V> inline hashtree<K,V> 
+ hashtree<K,V>::operator() (K key) {
+   realize ();