Add LLVM to Flake #12229
Add LLVM to Flake #12229
Conversation
RossComputerGuy
requested review from
Ericson2314 and
edolstra
as code owners
github-actions
bot
added
new-cli
There was a problem hiding this comment.
This will expose us to LLVM-Linux regressions in Nixpkgs when updating, but we could try with your help, which I see you're already providing in Nixpkgs.
Would it be ok to list you as a co-maintainer for this attribute?
(I don't think we're doing that kind of thing yet - could be a comment or perhaps also something in meta.maintainers, although I suspect that attr doesn't get much attention here)
| @@ -99,7 +99,7 @@ mkMesonExecutable (finalAttrs: { | |||
| mesonFlags = [ | |||
| ]; | |||
|
|
|||
| env = lib.optionalAttrs (stdenv.isLinux && !(stdenv.hostPlatform.isStatic && stdenv.system == "aarch64-linux")) { | |||
| env = lib.optionalAttrs (stdenv.isLinux && !(stdenv.hostPlatform.isStatic && stdenv.system == "aarch64-linux") && !(stdenv.hostPlatform.useLLVM)) { | |||
There was a problem hiding this comment.
Looks like these lines can all be moved to mesonBuildLayer
| @@ -282,6 +283,7 @@ | |||
| # These attributes go right into `packages.<system>`. | |||
| "${pkgName}" = nixpkgsFor.${system}.native.nixComponents.${pkgName}; | |||
| "${pkgName}-static" = nixpkgsFor.${system}.static.nixComponents.${pkgName}; | |||
| "${pkgName}-llvm" = nixpkgsFor.${system}.llvm.nixComponents.${pkgName}; | |||
There was a problem hiding this comment.
| "${pkgName}-llvm" = nixpkgsFor.${system}.llvm.nixComponents.${pkgName}; | |
| /** Nix and dependencies built with LLVM. */ | |
| "${pkgName}-llvm" = nixpkgsFor.${system}.llvm.nixComponents.${pkgName}; |
Yeah, that's why I'm trying to work on this. I'm wanting a full LLVM NixOS system and having Nix working properly on that would be ideal.
Sure |
Motivation
Fixes #12228
Context
Builds Nix with
pkgsLLVM, this allows for using Clang + libcxx and all dependencies needed for Nix are dependent on LLVM this way. Adding this in can help prevent regressions of Nix underpkgsLLVM.Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.