Handle bad DNS configuration while generating certificate #537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| return False | ||
|
|
||
| # Recreate the acme client with working domains | ||
| await self.cloud.client.async_create_repair_issue( |
There was a problem hiding this comment.
What are we asking users to do here?
There was a problem hiding this comment.
Currently nothing, this is a no-op untill its implemented in core.
But the idea here is to notify the user that we had to create a new certificate without their defined custom domain, and they would have to remove it from the account page, or fix the DNS config of that domain
Co-authored-by: Martin Hjelmare <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change brings in DNS validation before generating certificates.
If a bad DNS configuration is detected when there is < 25 days remaining a repair issue will be created with a warning severity.
If a bad DNS configuration is detected when there is < 18 days remaining a repair issue will be created with a error severity, and the acme client will be recreated without the custom domain.