Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Display clickable cursor on hover on petname component #29477

Merged
merged 1 commit into from
Jan 10, 2025

Conversation

pedronfigueiredo
Copy link
Contributor

@pedronfigueiredo pedronfigueiredo commented Jan 7, 2025

Description

Open in GitHub Codespaces

Related issues

Fixes: https://github.com/MetaMask/MetaMask-planning/issues/2340

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@pedronfigueiredo pedronfigueiredo added the team-confirmations Push issues to confirmations team label Jan 7, 2025
@pedronfigueiredo pedronfigueiredo self-assigned this Jan 7, 2025
Copy link
Contributor

github-actions bot commented Jan 7, 2025

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot
Copy link
Collaborator

Builds ready [589d961]
Page Load Metrics (1812 ± 38 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint28319921738345165
domContentLoaded1656194517908440
load1669196418127938
domInteractive28104452210
backgroundConnect770232010
firstReactRender1799462512
getState571212110
initialActions01000
loadScripts1183144613307636
setupStore682162110
uiStartup18582397208611656

@metamaskbot
Copy link
Collaborator

Builds ready [83f109a]
Page Load Metrics (1605 ± 207 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint125833531609423203
domContentLoaded125032851576413199
load125833871605431207
domInteractive219142199
backgroundConnect998272311
firstReactRender1573322210
getState46018178
initialActions00000
loadScripts90724531181310149
setupStore64712115
uiStartup143136711790456219
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@pedronfigueiredo pedronfigueiredo added this pull request to the merge queue Jan 10, 2025
Merged via the queue into main with commit 5778b4a Jan 10, 2025
80 checks passed
@pedronfigueiredo pedronfigueiredo deleted the pnf/2340 branch January 10, 2025 12:55
@github-actions github-actions bot locked and limited conversation to collaborators Jan 10, 2025
@metamaskbot metamaskbot added the release-12.11.0 Issue or pull request that will be included in release 12.11.0 label Jan 10, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.11.0 Issue or pull request that will be included in release 12.11.0 team-confirmations Push issues to confirmations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants