Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update to the latest transaction controller #29395

Merged
merged 2 commits into from
Dec 20, 2024
Merged

Conversation

pedronfigueiredo
Copy link
Contributor

@pedronfigueiredo pedronfigueiredo commented Dec 20, 2024

Description

Updates from v42 to v42.1 in order to get the validation of the gas limit hexadecimal string properties. See MetaMask/core#5093 for more details.

Open in GitHub Codespaces

Related issues

Fixes: https://github.com/MetaMask/MetaMask-planning/issues/3826

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@pedronfigueiredo pedronfigueiredo added the team-confirmations Push issues to confirmations team label Dec 20, 2024
@pedronfigueiredo pedronfigueiredo self-assigned this Dec 20, 2024
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Copy link

socket-security bot commented Dec 20, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@metamask/[email protected] None 0 348 kB metamaskbot
npm/@metamask/[email protected] network 0 2.19 MB metamaskbot

🚮 Removed packages: npm/@metamask/[email protected], npm/@metamask/[email protected]

View full report↗︎

cryptotavares
cryptotavares previously approved these changes Dec 20, 2024
@pedronfigueiredo
Copy link
Contributor Author

@metamaskbot update-policies

@pedronfigueiredo
Copy link
Contributor Author

@SocketSecurity ignore npm/@metamask/[email protected] npm/@metamask/[email protected]

@pedronfigueiredo
Copy link
Contributor Author

@metamaskbot update-policies

@metamaskbot
Copy link
Collaborator

Policies updated.
👀 Please review the diff for suspicious new powers.

🧠 Learn how: https://lavamoat.github.io/guides/policy-diff/#what-to-look-for-when-reviewing-a-policy-diff

@metamaskbot
Copy link
Collaborator

No policy changes

@metamaskbot
Copy link
Collaborator

Builds ready [9fa971b]
Page Load Metrics (1622 ± 48 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint39617681500359173
domContentLoaded14161792159810551
load1426179716229948
domInteractive228836189
backgroundConnect78526209
firstReactRender1679392512
getState55318178
initialActions01000
loadScripts1048137412079747
setupStore65410105
uiStartup16542057184811354
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 39.44 KiB (0.47%)

@pedronfigueiredo pedronfigueiredo added this pull request to the merge queue Dec 20, 2024
Merged via the queue into main with commit 547b264 Dec 20, 2024
77 checks passed
@pedronfigueiredo pedronfigueiredo deleted the pnf/3826 branch December 20, 2024 18:22
@github-actions github-actions bot locked and limited conversation to collaborators Dec 20, 2024
@metamaskbot metamaskbot added the release-12.11.0 Issue or pull request that will be included in release 12.11.0 label Dec 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.11.0 Issue or pull request that will be included in release 12.11.0 team-confirmations Push issues to confirmations team
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants