Migrate component to TS: Tag

[dhruvv173]

Explanation

• This PR fixes Migrate components to TS: Tag #19125

Screenshots/Screencaps

Before

After

unit test coverage

Manual Testing Steps

Pre-merge author checklist

• I've clearly explained:
  • What problem this PR is solving
  • How this problem was solved
  • How reviewers can test my changes
• Sufficient automated test coverage has been added

Pre-merge reviewer checklist

• Manual testing (e.g. pull and build branch, run in browser, test code being changed)
• PR is linked to the appropriate GitHub issue
• IF this PR fixes a bug in the release milestone, add this PR to the release milestone

If further QA is required (e.g. new feature, complex testing steps, large refactor), add the Extension QA Board label.

In this case, a QA Engineer approval will be be required.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[georgewrmarshall]

Hey @dhruvv173, I still need to do a full review but it looks like there are some snapshot and lining issues that need resolving?

[codecov]

Codecov Report

Merging #20086 (288cdff) into develop (23c30d9) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop   #20086      +/-   ##
===========================================
- Coverage    69.36%   69.36%   -0.00%     
===========================================
  Files          987      987              
  Lines        37289    37290       +1     
  Branches     10011    10012       +1     
===========================================
- Hits         25864    25863       -1     
- Misses       11425    11427       +2     

Impacted Files	Coverage Δ
ui/components/component-library/tag/tag.tsx	100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

[dhruvv173]

Hey @dhruvv173, I still need to do a full review but it looks like there are some snapshot and lining issues that need resolving?

addressed issues in the recent commit, passes all the tests. However, I think we'll also need a review from snaps engineer?

[garrettbear]

Hey @dhruvv173, I still need to do a full review but it looks like there are some snapshot and lining issues that need resolving?

addressed issues in the recent commit, passes all the tests. However, I think we'll also need a review from snaps engineer?

Yes we will get someone from snaps to review

[garrettbear]

Looking really good @dhruvv173! I committed my suggestions to your PR, so be sure to pull locally if you end up needing to do any changes.

[dhruvv173]

Looking really good @dhruvv173! I committed my suggestions to your PR, so be sure to pull locally if you end up needing to do any changes.

Yes, will do. Thank you so much for making the changes!

[georgewrmarshall]

I suppose this is fine but would note that this prevents things like <Tag labelProps={{ as: 'p' }} />

[georgewrmarshall]

Left one comment, we may want to remove some of the styling on he Tag component in future so we can use the style utility props more

[georgewrmarshall]

LGTM! Thanks for your contribution @dhruvv173 and for supporting @garrettbear

[dhruvv173]

thanks alot for assisting @garrettbear :)