-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Part of #18714: Replacing deprecated constants #20003
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
ui/components/app/qr-hardware-popover/qr-hardware-sign-request/player.js
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## develop #20003 +/- ##
===========================================
- Coverage 69.42% 69.42% -0.01%
===========================================
Files 990 990
Lines 37418 37418
Branches 10039 10039
===========================================
- Hits 25976 25974 -2
- Misses 11442 11444 +2
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for your contribution
Explanation
Made changes to the following files
ui/components/app/qr-hardware-popover/qr-hardware-sign-request/player.js
ui/components/app/signature-request-siwe/signature-request-siwe-icon/index.js
ui/components/app/signature-request-siwe/signature-request-siwe-tag/index.js
ui/components/app/tab-bar/tab-bar.js
Screenshots/Screencaps
Created story for
Player
SignatureRequestSiweIcon
Before
After
SignatureRequestSiweTag
Before
After
TabBar
Before
After
Manual Testing Steps
Pre-merge author checklist
Pre-merge reviewer checklist
If further QA is required (e.g. new feature, complex testing steps, large refactor), add the
Extension QA Board
label.In this case, a QA Engineer approval will be be required.