-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Label component font weight from bold to medium #19731
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @Jainex17, thanks for your contribution could you please add some before and after screenshots of the Label component in storybook so others can see the visual changes. I also replaced some deprecated instances of consts. Thanks
Codecov Report
@@ Coverage Diff @@
## develop #19731 +/- ##
===========================================
- Coverage 69.83% 69.82% -0.01%
===========================================
Files 979 979
Lines 36905 36905
Branches 9909 9909
===========================================
- Hits 25769 25767 -2
- Misses 11136 11138 +2
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated PR with screencast of before/after. LGTM. Thanks for your contribution
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Explanation
Change Made
Screenshots
Before
before.mov
After
after.mov
Pre-merge author checklist
Pre-merge reviewer checklist