Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Label component font weight from bold to medium #19731

Merged
merged 5 commits into from
Jun 26, 2023

Conversation

Jainex17
Copy link
Contributor

@Jainex17 Jainex17 commented Jun 23, 2023

Explanation

Change Made

  1. Updated the Label component's font weight from bold to medium in the label.js file.
  2. Update Snapshots.

Screenshots

Before

before.mov

After

after.mov

Pre-merge author checklist

  • I've clearly explained:
    • What problem this PR is solving
    • How this problem was solved
    • How reviewers can test my changes
  • Sufficient automated test coverage has been added

Pre-merge reviewer checklist

  • Manual testing (e.g. pull and build branch, run in browser, test code being changed)
  • PR is linked to the appropriate GitHub issue
  • IF this PR fixes a bug in the release milestone, add this PR to the release milestone

@Jainex17 Jainex17 requested a review from a team as a code owner June 23, 2023 08:15
@Jainex17 Jainex17 requested a review from NidhiKJha June 23, 2023 08:15
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@georgewrmarshall georgewrmarshall added the team-design-system All issues relating to design system in Extension label Jun 23, 2023
Copy link
Contributor

@georgewrmarshall georgewrmarshall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Jainex17, thanks for your contribution could you please add some before and after screenshots of the Label component in storybook so others can see the visual changes. I also replaced some deprecated instances of consts. Thanks

@codecov
Copy link

codecov bot commented Jun 23, 2023

Codecov Report

Merging #19731 (9c31198) into develop (ed06926) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop   #19731      +/-   ##
===========================================
- Coverage    69.83%   69.82%   -0.01%     
===========================================
  Files          979      979              
  Lines        36905    36905              
  Branches      9909     9909              
===========================================
- Hits         25769    25767       -2     
- Misses       11136    11138       +2     
Impacted Files Coverage Δ
ui/components/component-library/label/label.js 100.00% <ø> (ø)

... and 2 files with indirect coverage changes

Copy link
Contributor

@georgewrmarshall georgewrmarshall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated PR with screencast of before/after. LGTM. Thanks for your contribution

Copy link
Member

@NidhiKJha NidhiKJha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NidhiKJha NidhiKJha merged commit c1c6c82 into MetaMask:develop Jun 26, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jun 26, 2023
@Jainex17 Jainex17 deleted the Update-Label-fontWeight branch June 27, 2023 09:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
external-contributor team-design-system All issues relating to design system in Extension
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Label component font weight
3 participants