Replacing deprecated constants and adding new stories #19563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
|
hey @georgewrmarshall, could you please review this PR? |
Codecov Report
@@ Coverage Diff @@
## develop #19563 +/- ##
===========================================
- Coverage 69.45% 69.43% -0.01%
===========================================
Files 985 985
Lines 37289 37289
Branches 10015 10015
===========================================
- Hits 25896 25891 -5
- Misses 11393 11398 +5 |
Goldmouth81
approved these changes
Jun 12, 2023
georgewrmarshall
added
the
team-design-system
DDDDDanica
previously approved these changes
Jun 13, 2023
georgewrmarshall
previously approved these changes
Jun 14, 2023
NidhiKJha
previously approved these changes
Jun 15, 2023
FrederikBolding
previously requested changes
Jun 20, 2023
|
the font size change looks straightforward, once the other suggestion is resolved we can make changes @georgewrmarshall |
georgewrmarshall
dismissed stale reviews from NidhiKJha and themself
via
20f698d
georgewrmarshall
force-pushed
the
issue/replacing-deprecated-constants
branch
from
5cb0b31 to
e8d640b
Compare
georgewrmarshall
force-pushed
the
issue/replacing-deprecated-constants
branch
from
e8d640b to
e0ab16d
Compare
georgewrmarshall
force-pushed
the
issue/replacing-deprecated-constants
branch
from
e0ab16d to
ef6c415
Compare
georgewrmarshall
force-pushed
the
issue/replacing-deprecated-constants
branch
from
ef6c415 to
3d3dfc7
Compare
georgewrmarshall
approved these changes
Jul 24, 2023
garrettbear
approved these changes
Jul 25, 2023
Mrtenz
approved these changes
Jul 25, 2023
georgewrmarshall
dismissed
FrederikBolding’s stale review
Suggestions have been resolved and reviewed by Maarten, another snaps engineer
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
SnapRemoveWarningandSnapUIMarkdownui/components/app/snaps/snap-remove-warningui/components/app/snaps/snap-ui-markdownScreenshots/Screencaps
SnapRemoveWarningSnapUIMarkdownManual Testing Steps
yarn storybookSnapRemoveWarningandSnapUIMarkdownPre-merge author checklist
Pre-merge reviewer checklist
If further QA is required (e.g. new feature, complex testing steps, large refactor), add the
Extension QA Boardlabel.In this case, a QA Engineer approval will be be required.