Moving RESIZE
constant to textarea component folder
#19240
Merged
+15
−18
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
RESIZE
constant to textarea component folder #19233Moved
RESIZE
constant to textarea component foldermetamask-extension\ui\components\ui\textarea\textarea.constants.js
and made changesI also replaced the deprecated
BLOCK_SIZES
constant withBlockSize
enumTo assist the reviewers in verifying that no visual changes have occurred after implementing the changes, I have attached the before and after screenshots below.
Screenshots/Screencaps
Before
After
Manual Testing Steps
yarn jest ui/components/ui/textarea
passed 8 testsPre-merge author checklist
Pre-merge reviewer checklist
If further QA is required (e.g. new feature, complex testing steps, large refactor), add the
Extension QA Board
label.In this case, a QA Engineer approval will be be required.